Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imports for docker-container monitors are not correctly restored. #2015

Closed
2 tasks done
mmuenker opened this issue Aug 25, 2022 · 2 comments
Closed
2 tasks done

Imports for docker-container monitors are not correctly restored. #2015

mmuenker opened this issue Aug 25, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@mmuenker
Copy link

⚠️ Please verify that this bug has NOT been raised before.

  • I checked and didn't find similar issue

🛡️ Security Policy

Description

The container-name and the selected docker host is not restored but empty.

The properties container-name and docker host are correctly exported and appear in the JSON file.

👟 Reproduction steps

Create docker-container monitor and create a backup. Then import the backup (with overwrite)

👀 Expected behavior

The docker-container monitor is restored with the container-name and docker host.

😓 Actual Behavior

The restored docker-container monitor has empty container-name and docker host inputs.

🐻 Uptime-Kuma Version

1.18.0-beta.0

💻 Operating System and Arch

Ubuntu 22.04 amd64

🌐 Browser

Chromium 104.0.5112.101

🐋 Docker Version

Docker 20.10.17

🟩 NodeJS Version

No response

📝 Relevant log output

No response

@chakflying
Copy link
Collaborator

Obsolete as the backup feature has been dropped in #3892.

@chakflying chakflying closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2023
@CommanderStorm
Copy link
Collaborator

Chiming in with a more in-depth explanation:

Please see #2141 (comment)

In 1.18.3, the backup feature was deprecated due to [being left] unmaintained.

Backup & Restore with JSON has been deprecated and issues will not be fixed due to the amount of problems it has been causing for our users and us.
The current design is just not maintainable, causing countless bugs.
In v2.0 the deprecated backup tool is being removed because of this reason.
Please consider using SQL, API based1 or infrastructure based2 backup instead.

New approaches to these features should use SQLite dump or MariaDB dump respectively. (Here is our contribution guide)

You can subscribe to these issues meanwhile:

Footnotes

  1. using the third-party API: https://uptime-kuma-api.readthedocs.io/en/latest/

  2. see https://github.com/louislam/uptime-kuma/issues/477#issuecomment-1557966187 for a setup example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants