refactor: enable type checks inside mixin classes #5394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
requested review from
agnes512,
deepakrkris,
emonddr,
hacksparrow and
jannyHou
as code owners
bajtos
commented
May 12, 2020
| @@ -57,26 +48,42 @@ export function BootMixin<T extends Constructor<any>>(superClass: T) { | |||
| () => this.projectRoot, | |||
| ); | |||
| this.bind(BootBindings.BOOT_OPTIONS).toDynamicValue( | |||
| () => this.bootOptions, | |||
| () => this.bootOptions ?? {}, | |||
There was a problem hiding this comment.
This problem was hidden by any before.
| this.mountComponentBooters(component); | ||
| return binding; |
There was a problem hiding this comment.
This problem was hidden by any before.
| this.mountComponentRepositories(component); | ||
| const binding = super.component(componentCtor, nameOrOptions); | ||
| this.mountComponentRepositories(componentCtor); | ||
| return binding; |
There was a problem hiding this comment.
This problem was hidden by any before.
bajtos
force-pushed
the
refactor/better-mixin-types
branch
from
0186756
to
4c03819
Compare
raymondfeng
reviewed
May 12, 2020
raymondfeng
reviewed
May 12, 2020
raymondfeng
reviewed
May 12, 2020
bajtos
force-pushed
the
refactor/better-mixin-types
branch
from
4c03819
to
f1e862c
Compare
hacksparrow
approved these changes
May 13, 2020
Introduce a new type helper `MixinTarget` allowing mixin functions to accept a type that describes public members of the target class only. This is working around the current TypeScript limitations. Rework all existing mixins and the related documentation to use `MixinTarget<RealClass>` instead of `Constructor<any>`. Fix any errors discovered by the compiler after enabling type checks. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
bajtos
force-pushed
the
refactor/better-mixin-types
branch
from
f1e862c
to
d8bcc88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new type helper
MixinTargetallowing mixin functions to accept a type that describes public members of the target class only. This is working around the current TypeScript limitations:declaration: truemicrosoft/TypeScript#17293privatemembers microsoft/TypeScript#36060Rework all existing mixins and the related documentation to use
MixinTarget<RealClass>instead ofConstructor<any>.Fix any errors discovered by the compiler after enabling type checks.
See also microsoft/TypeScript#38496
This PR depends on loopbackio/loopback-datasource-juggler#1839, the build will keep failing until a new version of juggler is released & loopback-next package locks are updated.Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈