types: allow no models argument for automigrate
#1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
requested review from
dhmlau,
emonddr,
jannyHou and
zbarbuto
as code owners
bajtos
force-pushed
the
fix-types/datasource-migrate
branch
from
737633b
to
ab50055
Compare
4 tasks
Fix type definitions to allow zero-argument invocation of the following database migration methods: - `DataSource.automigrate()` - `DataSource.autoupdate()` Implementation-wise, when no model names are specified, then ALL models attached to the datasource are migrated. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
bajtos
force-pushed
the
fix-types/datasource-migrate
branch
from
ab50055
to
4c53aba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix type definitions to allow zero-argument invocation of the following database migration methods:
DataSource.automigrate()DataSource.autoupdate()Implementation-wise, when no model names are specified, then ALL models attached to the datasource are migrated.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machine