Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to typescript 5.0 and use new decorator API #1405

Merged
merged 18 commits into from
May 4, 2023
Merged

Conversation

lolopinto
Copy link
Owner

new decorator API created in https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#decorators

this involves breaking changes since API for gqlField et al have changed.

The API is still not perfect:

  @gqlField({
    nodeName: "User",
    type: GraphQLString,
    name: "fullName",
  })
  get fullName(): string {
    return this.firstName + " " + this.lastName;
  }

as we have to reference nodeName: 'User' in each gqlField definition which is annoying since the new decorator API provides less access to things than the previous one did.

Another big change is gqlArg is gone since parameter arguments aren't supported tc39/proposal-decorators#47

addresses #1392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant