-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codegen with swc on cross platform dev + docker not working #1496
Comments
(I think I can just update the base classes myself easily enough to add in this one change, but that feels sketchy - I'd expect the framework to re-gen generated files for me) |
I believe it's because the image needs to change too. can you try with the latest image update your
|
I just updated ent-starter images too |
Thanks for the quick response. Just so I'm clear on a couple of things:
To your actual suggestion. I have tried upgrading as you suggested, but am running into problems. Here's what I've done:
Now, if I run eg
|
Oh, but that might be because I've not updated all the |
Are the docs here up to date? i.e. should it be something like:
(as per the docs), or
Am assuming the latter, as per the simple example. Will update my code assuming that's the case. |
yes, you should end up with them |
yes how can I make that clearer? |
not sure what this missing bindings issue is? if you're still seeing them, can you add e.g. around https://github.com/lolopinto/ent/blob/main/examples/simple/docker-compose.dev.yml#L16 |
thanks for going through again. I'm about to release v0.1 and planned to do a documentation refresh around all the issues tagged with |
I'm not sure you need to. My assumption was that this would be the case, but having run into issues I was doubting it. What I don't quite understand is that I started this project a couple of months ago using So I don't think this is a bodged upgrade issue. Although it's possible I just happened to pick a version of the framework where this transition was in progress? |
OK, adding the
FWIW I tried twice and had a different error the first time:
|
Should also say that fixing up the gql field changes has fixed running the server with |
I'm afraid I've got to bounce for the night - am on holiday and should probably spend some time with my wife :) If useful, I've added you to the project on GH to have a look around - https://github.com/LimeAndSoda/roomtool-server/tree/upgrade2 is the branch that I'm running the upgrade in. |
cool thanks. will take a look later! |
changes I made:
^ related to documentation changes with 5.0 in changed from
I think those were the 2 big ones. everything else was small stuff. had to create local db, had to change docker-compose.dev.yml to work for |
Oh amazing, thank you! Confirmed that's got both Although I'm still having issues if I don't disable SWC. I'll keep that disabled for now, but let me know if you'd like any help/testing/whatever later with that. Thanks again! |
can you try with this image
i made a small tweak and wanna see if it works? it works for me but i had done some debugging and not 100% sure if i somehow changed something independently |
Steps:
Same issue as before I'm afraid:
|
And just for completeness, if I re-add the flag to disable SWC in docker-compose.dev.yaml:
|
ok, thanks! :( |
I've been playing with it for a while and I can't 100% reliably solve it. I think it's something to do with |
Which package manager are you using yourself? If not yarn, would it help for me to repro the absence of an error with the other package manager? |
I'm using npm. I'll figure it out with yarn. Was just giving an update so it wouldn't look like I forgot about it. |
Thanks! |
ok, i played with it even more and i believe i narrowed it down when i had been using this for development, i had been building on an arm64 mac and building things locally without using docker in production, doing it on an amd64 linux box and the docker image mirrors that the issue that you were running into was the platform mismatch. there's ways around it but doesn't seem like it's worth doing that by default so i'm changing the behavior to not use swc and now to enable SWC need to use |
i assume you're on a mac? are you on arm64 or amd64? if arm64, can you try this image https://github.com/lolopinto/ent/pkgs/container/ent/107819773?tag=0.1.0-alpha.50-test7-nodejs-18-dev amd64 https://github.com/lolopinto/ent/pkgs/container/ent/107822985?tag=0.1.0-alpha.50-test8-nodejs-18-dev different images because i was testing and faster to create single platform images with things work for me with these |
OK, so this time:
|
Tried adding
|
the first one should have failed so that's not surprising since no dependency and the default is no extra envs and it should work because it's not doing SWC the latter not working is maddening lol. i tested it multiple times the other day but yup, not working for me anymore. I think I'm going to punt on this for now and come back to it later with the node_modules hidden from docker approach. my guess is we need to run yarn install in |
thanks for debugging with me |
You're welcome! |
Yeah, I didn't test this because AIUI this is a problem with SWC. Let me know if you do want me to test this, but assume not for now. |
I'm getting a load of errors of the form:
I was using
0.1.0-alpha30
, attempting to update to0.1.0-alpha147
but that doesn't appear to have made a difference.Unsure how best to diagnose. I can see the property exists in the latest version of the ent code (here).
Should I just remove all the generated files and re-gen? Is that safe?
Thanks :)
The text was updated successfully, but these errors were encountered: