-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: refactor setup and get all tests passing #442
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7820628
CI: drop customized Dockerfile
kares b9e38b4
bring back apt install openssl
kares 70de9ea
Test: fix failure when ECS mode is on (8.x)
kares 138400a
Test: refactor for easier debugging
kares 77c6d46
Temp: only run it spec - debug Ubuntu 8.x fail
kares 6d57bf9
Refactor to using a before(:all) hook
kares 46eebb1
Test: print failures when retry-ing
kares 66eb0ea
proper -subj (second try)
kares 9bf7fea
Temp: debug plugin
kares 3a5e351
restore the it spec working again (on 7.x)
kares 35f5c83
revert temp LOG_LEVEL=debug
kares 8adfc30
will need to keep using -v1 algorithm
kares a73f353
revert back to running all specs
kares File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
#!/bin/bash | ||
|
||
if [ $(command -v apt) ]; then | ||
sudo apt install -y openssl | ||
else | ||
sudo yum install -y openssl | ||
fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,6 +50,7 @@ | |
begin | ||
beats.run(queue) | ||
rescue => e | ||
warn e.inspect if $VERBOSE | ||
retry unless beats.stop? | ||
end | ||
end | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have a test case for tls metadata in ecs mode, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be elsewhere - recall writing this spec as specifically guarding against a NPE regression,
the bug surfaced regardless of
ecs_compatibility
and the test's intention isn't verifying ECS vs non-ECS field behavior (I understand it might seem so on first sight).