Fix: LS failing with ssl_peer_metadata => true
#431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We broke being able to enhance events with TLS meta-data (such as the protocol used) since 6.1.0 (with the introduction of ECS).
Running with
ssl_peer_metadata => truealways leads to a NPE as name fields are assumed on a object instance while they exist on the plugin instance ->Java::OrgLogstash::FieldReference.from(nil)which does not acceptnull.The fix is to properly read the field names.
The reason this broke is likely due the difficulties unit testing (mocking) these parts, we should now have a test that exercises the TLS meta-data code path.