Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devtools): load Vue devtools lazily #4946

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

logaretm
Copy link
Owner

What

It was noticed in #4943 that the devtools gets bundled in as a result of it being an imported dependency.

I will experiment with lazy loading it and see if it works well or not, since I do not think I can force it to be tree-shaken.

@logaretm logaretm self-assigned this Nov 19, 2024
@logaretm logaretm linked an issue Nov 19, 2024 that may be closed by this pull request
5 tasks
Copy link

changeset-bot bot commented Nov 19, 2024

🦋 Changeset detected

Latest commit: ea3acc3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
vee-validate Patch
@vee-validate/joi Patch
@vee-validate/nuxt Patch
@vee-validate/rules Patch
@vee-validate/valibot Patch
@vee-validate/yup Patch
@vee-validate/zod Patch
@vee-validate/i18n Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@logaretm logaretm force-pushed the 4943-vue-devtools-included-in-production-bundle branch from d107d17 to ea3acc3 Compare November 19, 2024 22:00
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.25%. Comparing base (14122af) to head (ea3acc3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4946   +/-   ##
=======================================
  Coverage   89.25%   89.25%           
=======================================
  Files          93       93           
  Lines        7995     7995           
  Branches     1387     1387           
=======================================
  Hits         7136     7136           
  Misses        852      852           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@logaretm logaretm merged commit 30281f5 into main Nov 20, 2024
7 checks passed
@logaretm logaretm deleted the 4943-vue-devtools-included-in-production-bundle branch November 20, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue Devtools included in production bundle
1 participant