-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue Devtools included in production bundle #4943
Comments
Good catch, I think while vee-validate's code gets dropped correctly, it still bundles in the devtools code because it is imported as a dependency. I will experiment with maybe lazy loading it because i don't want to lose the ability to auto-install the devtools plugin whenever vee-validate is used. |
Ah, gotcha, so VeeValidate's dev-tools related code was getting dropped, but just not the underlying (related) Vue devtools themselves...that makes a lot of sense (hadn't connected those dots before 🤦). Agreed the the ability to auto-install the devtools plugin is super useful though; I really appreciate having the devtools integration ❤️! |
What happened?
When generating a production build, it appears that some Vue Devtools code is included in the build (due to VeeValidate). This is unexpected, as in production any devtools-related code should not be included (to decrease bundle size, etc). While the docs mention that the devtools are not installed in production builds, they still appear to be imported/included in bundle?
Reproduction steps
vee-validate
in a projectrollup-plugin-visualizer
(configure withsourcemaps: true
)devtools-kit/dist/index.js
is included in buildVersion
Vue.js 3.x and vee-validate 4.x
What browsers are you seeing the problem on?
Relevant log output
No response
Demo link
Not reproducible in CodeSandbox (requires build environment)
Code of Conduct
The text was updated successfully, but these errors were encountered: