-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backend: hand revocation entries to silo, make sure all metadata fields are set #707
Merged
fengelniederhammer
merged 2 commits into
main
from
704-backend-hand-null-entries-to-silo
Jan 24, 2024
Merged
backend: hand revocation entries to silo, make sure all metadata fields are set #707
fengelniederhammer
merged 2 commits into
main
from
704-backend-hand-null-entries-to-silo
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengelniederhammer
force-pushed
the
704-backend-hand-null-entries-to-silo
branch
2 times, most recently
from
December 22, 2023 15:02
b8e4dbb
to
97d32c0
Compare
backend/src/main/kotlin/org/pathoplexus/backend/controller/SubmissionController.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/pathoplexus/backend/service/submission/DatabaseService.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/pathoplexus/backend/service/submission/DatabaseService.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/pathoplexus/backend/service/submission/DatabaseService.kt
Outdated
Show resolved
Hide resolved
...end/src/main/kotlin/org/pathoplexus/backend/service/submission/EmptyProcessedDataProvider.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/pathoplexus/backend/api/SubmissionTypes.kt
Outdated
Show resolved
Hide resolved
fengelniederhammer
force-pushed
the
704-backend-hand-null-entries-to-silo
branch
from
January 23, 2024 16:24
97d32c0
to
3d3b16b
Compare
SILO is prepared, so this could be merged now. |
fengelniederhammer
force-pushed
the
704-backend-hand-null-entries-to-silo
branch
from
January 23, 2024 16:35
3d3b16b
to
f61c9fc
Compare
2 tasks
fengelniederhammer
force-pushed
the
704-backend-hand-null-entries-to-silo
branch
from
January 24, 2024 08:09
f61c9fc
to
1f4df1c
Compare
JonasKellerer
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...end/src/test/kotlin/org/loculus/backend/service/submission/EmptyProcessedDataProviderTest.kt
Outdated
Show resolved
Hide resolved
fengelniederhammer
force-pushed
the
704-backend-hand-null-entries-to-silo
branch
from
January 24, 2024 09:10
1f4df1c
to
267cbef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #704
resolves #429
This PR serves as data source for the implementation is SILO, merge needs to wait until GenSpectrum/LAPIS-SILO#220 is done.