Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small tweaks to test-prepro-v2 #2973

Merged
merged 10 commits into from
Oct 25, 2024
Merged

Small tweaks to test-prepro-v2 #2973

merged 10 commits into from
Oct 25, 2024

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Oct 8, 2024 •
edited by anna-parker
Loading

Preview: https://test-prepro-v2-cr.loculus.org/

Use pytest instead of unittest: results in nicer test result view:

iTerm2 2024-10-08 13 29 12 iTerm2 2024-10-08 13 29 16

Just run via pytest

@corneliusroemer corneliusroemer force-pushed the test-prepro-v2-cr branch 2 times, most recently from 4725cee to 8068810 Compare October 8, 2024 10:37
@corneliusroemer corneliusroemer changed the title refactor get_config Small tweaks to test-prepro-v2 Oct 8, 2024
@corneliusroemer corneliusroemer mentioned this pull request Oct 8, 2024
Merged
2 tasks
Base automatically changed from test_prepro_v2 to main October 8, 2024 12:03
@corneliusroemer corneliusroemer marked this pull request as ready for review October 8, 2024 12:39
anna-parker
anna-parker requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@anna-parker anna-parker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some more thoughts, somehow the tests aren't running for me with the pytest command - similar to the CI I see no tests ran in 0.00s

preprocessing/nextclade/tests/factory_methods.py Outdated Show resolved Hide resolved
preprocessing/nextclade/tests/factory_methods.py Outdated Show resolved Hide resolved
preprocessing/nextclade/tests/test.py Outdated Show resolved Hide resolved
preprocessing/nextclade/tests/test.py Outdated Show resolved Hide resolved
@corneliusroemer
Copy link
Contributor Author

Heh, pytest has some expectations for filenames, they must start or end with test_/_test - that's why it worked until I renamed test_pytest.py to test.py

@anna-parker anna-parker self-requested a review October 25, 2024 14:05
@anna-parker anna-parker added the preview Triggers a deployment to argocd label Oct 25, 2024
@anna-parker
Copy link
Contributor

Wupps some issues post rebase:
image

@anna-parker anna-parker removed the preview Triggers a deployment to argocd label Oct 25, 2024
@anna-parker anna-parker added the preview Triggers a deployment to argocd label Oct 25, 2024
anna-parker
anna-parker approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@anna-parker anna-parker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preview looks great! tests are passing (and dont pass when I break them ;-) ) - LGTM!

@anna-parker anna-parker merged commit a1897df into main Oct 25, 2024
16 checks passed
@anna-parker anna-parker deleted the test-prepro-v2-cr branch October 25, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anna-parker anna-parker anna-parker approved these changes

Assignees
No one assigned
Labels
preview Triggers a deployment to argocd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corneliusroemer @anna-parker