Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have plumber in default maximizer string in plumber #387

Merged
merged 1 commit into from
May 23, 2020
Merged

have plumber in default maximizer string in plumber #387

merged 1 commit into from
May 23, 2020

Conversation

taltamir
Copy link
Contributor

@taltamir taltamir commented May 21, 2020 •
edited
Loading

Description

in default maximizer string include plumber when in_zelda()

Fixes #325 subissue 1

How Has This Been Tested?

part of a softcore plumber run.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have based by pull request against the beta branch or have a good reason not to.

@taltamir taltamir force-pushed the zelda branch 2 times, most recently from 9f947ef to a143374 Compare May 22, 2020 19:23
@taltamir taltamir merged commit c8f4144 into loathers:beta May 23, 2020
@taltamir taltamir deleted the zelda branch May 23, 2020 18:10
@taltamir taltamir changed the title have plumber in default string in plumber have plumber in default maximizer string in plumber May 28, 2020
@taltamir taltamir mentioned this pull request May 28, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rinn Rinn Rinn approved these changes

@daniellockard daniellockard Awaiting requested review from daniellockard

@soolar soolar Awaiting requested review from soolar

@macgregor macgregor Awaiting requested review from macgregor

@Malibu-Stacey Malibu-Stacey Awaiting requested review from Malibu-Stacey

@Phate4569 Phate4569 Awaiting requested review from Phate4569

@jeparo jeparo Awaiting requested review from jeparo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taltamir @Rinn