[plumber] Fix failures at Haunted Bedroom and Bat Hole #328
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taltamir
approved these changes
Apr 19, 2020
This was referenced Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Haunted Bedroom was skipping the pre-adventure handler and so adventuring without equipping a plumber tool.
In Plumber runs, we were infinite-looping at the Bat Hole, trying to adventure in the Lair after defeating the Boss Bat-equivalent. This was because Mafia wasn't updating the quest tracking property when we beat the substitute boss in Plumber. I fixed this by visit_url-ing the Bat Hole after adventuring in the Boss Bat's zone. This is definitely an upstream Mafia bug, though. Ah well.
How Has This Been Tested?
Both were tested via observing the crash locally, re-running to confirm that the bug persisted through restarts, adding the change, and confirming that the bug disappeared. This should avoid a false positive, where the bug wasn't actually fixed by my code but I assumed it was because hey, it cleared up after I ran my code.
Checklist: