[plumber] Always equip plumber combat tool before Ed fight #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeparo
requested review from
taltamir and
Malibu-Stacey
and removed request for
taltamir
Malibu-Stacey
approved these changes
Apr 18, 2020
|
All seems reasonable. |
taltamir
approved these changes
Apr 19, 2020
There was a problem hiding this comment.
Code looks good. And even though you only tested it for 2 minutes, they were highly focused 2 mintues where you went from failing to equip gear to fight ed, to successfully equipping gear to fight ed. Additionally this is currently broken and every single person running autoscend on plumber gets this crash every time they face ed. So I say merge it.
|
Also huh. apparently my subissue 1 in #325 is multiple issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ed fighting disables the standard pre-adventure handling, so calls to autoEquip() never happen and the pre-adventure code that would normally force-equip Plumber tools never gets called. This adds a utility function for equipping Plumber tools, calls it before fighting Ed, calls
equipMaximized()before fighting Ed, and refactors the existing pre-adventure Plumber code to use this utility function.This also fixes a long-standing bug where we wouldn't equip lots of stuff we intended to equip before fighting Ed.
Relevant to #325
How Has This Been Tested?
An automated run ran into the above Ed crash. I made the listed changes and re-ran autoscend. It equipped the fancy boots and defeated Ed. So I have tested this for about two minutes total, but it seems promising.
Checklist: