Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter out eval traces in the traces page (#342) #343

Merged
merged 1 commit into from
Jan 21, 2025
Merged

filter out eval traces in the traces page (#342) #343

merged 1 commit into from
Jan 21, 2025

Conversation

dinmukhamedm
Copy link
Member

@dinmukhamedm dinmukhamedm commented Jan 21, 2025

Important

Filters out non-'DEFAULT' trace types in GET function in route.ts.

  • Behavior:
    • Filters out traces with traceType not equal to 'DEFAULT' in GET function in route.ts.

This description was created by Ellipsis for 1948c1c. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 1948c1c in 10 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/app/api/projects/[projectId]/traces/route.ts:95
  • Draft comment:
    Ensure that the traceType filter is applied consistently across all relevant queries. It seems to be correctly added to the main query, but double-check any other queries that might need this filter.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The addition of the filter for traceType is consistent with the PR's intent to filter out non-DEFAULT traces.

Workflow ID: wflow_aspapwOgU3RzmnY0


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@dinmukhamedm dinmukhamedm merged commit 95118b1 into main Jan 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant