Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter out eval traces in the traces page #342

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

dinmukhamedm
Copy link
Member

@dinmukhamedm dinmukhamedm commented Jan 21, 2025

Important

Filters out non-'DEFAULT' trace types in the GET function of route.ts.

  • Behavior:
    • Filters out traces with traceType not equal to 'DEFAULT' in GET function in route.ts.
    • Ensures only 'DEFAULT' traces are retrieved for the specified project and date range.

This description was created by Ellipsis for bf61e59. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to bf61e59 in 9 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/app/api/projects/[projectId]/traces/route.ts:95
  • Draft comment:
    The addition of eq(traces.traceType, 'DEFAULT') correctly filters out non-default trace types, aligning with the PR's intent to exclude eval traces.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The addition of the filter for traceType to be 'DEFAULT' is consistent with the PR title, which aims to filter out eval traces. This change is correctly applied in the baseQuery where clause.

Workflow ID: wflow_64dT0nCpi6RYjiHJ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@dinmukhamedm dinmukhamedm merged commit 1948c1c into dev Jan 21, 2025
2 checks passed
@dinmukhamedm dinmukhamedm deleted the fix/traces-query branch January 21, 2025 08:12
dinmukhamedm added a commit that referenced this pull request Jan 21, 2025
filter out eval traces in the traces page (#342)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant