-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various qdrant fixes #341
Merged
Merged
Various qdrant fixes #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* configure new spans collections to store data on disk * store dense vectors on disk as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 472e023 in 2 minutes and 8 seconds
More details
- Looked at
665
lines of code in17
files - Skipped
0
files when reviewing. - Skipped posting
8
drafted comments based on config settings.
1. app-server/src/main.rs:376
- Draft comment:
The removal ofchunker_runner
from the function call is consistent with the updated logic that no longer requires chunking. Ensure that all related logic is updated accordingly. - Reason this comment was not posted:
Confidence changes required:20%
The removal of thechunker_runner
parameter from theprocess_queue_spans
function and its internal calls is consistent with the removal of the chunking logic from theindex_span
function. This change simplifies the function signature and aligns with the updated logic that no longer requires chunking.
2. app-server/src/projects/mod.rs:50
- Draft comment:
The removal ofcreate_collection
calls is consistent with the updated logic that no longer requires these collections. Ensure that all related logic is updated accordingly. - Reason this comment was not posted:
Confidence changes required:20%
The removal of thecreate_collection
calls increate_project
is consistent with the removal of chunking logic. This change simplifies the project creation process and aligns with the updated logic that no longer requires these collections.
3. app-server/src/traces/consumer.rs:11
- Draft comment:
The removal ofchunker_runner
from the function call is consistent with the updated logic that no longer requires chunking. Ensure that all related logic is updated accordingly. - Reason this comment was not posted:
Confidence changes required:20%
The removal of thechunker_runner
parameter from theprocess_queue_spans
function and its internal calls is consistent with the removal of the chunking logic from theindex_span
function. This change simplifies the function signature and aligns with the updated logic that no longer requires chunking.
4. app-server/src/traces/index.rs:5
- Draft comment:
The removal of thechunk
function and related logic is consistent with the updated logic that no longer requires chunking. Ensure that all related logic is updated accordingly. - Reason this comment was not posted:
Confidence changes required:20%
The removal of thechunk
function and related logic is consistent with the updated logic that no longer requires chunking. This change simplifies the indexing process and aligns with the updated logic.
5. frontend/app/api/workspaces/route.ts:10
- Draft comment:
TheGET
function now directly queries the database for workspaces and their projects, improving performance and reducing external dependencies. - Reason this comment was not posted:
Confidence changes required:10%
TheGET
function now directly queries the database for workspaces and their projects, which is more efficient than the previous approach of fetching from an external API. This change improves performance and reduces external dependencies.
6. frontend/components/projects/project-card.tsx:12
- Draft comment:
TheProjectCard
component has been simplified by removing theCard
component wrapper, reducing complexity and aligning with the updated design. - Reason this comment was not posted:
Confidence changes required:10%
TheProjectCard
component has been simplified by removing theCard
component wrapper. This change reduces the complexity of the component and aligns with the updated design.
7. frontend/components/traces/chat-message-list-tab.tsx:34
- Draft comment:
TheContentPartImageUrl
function now correctly appends?payloadType=image
to relative URLs, ensuring correct handling of images stored in S3. - Reason this comment was not posted:
Confidence changes required:10%
TheContentPartImageUrl
function now correctly appends?payloadType=image
to relative URLs, ensuring that images stored in S3 are correctly identified. This change improves the handling of image URLs.
8. frontend/components/traces/span-card.tsx:47
- Draft comment:
ThesetSegmentHeight
function now usesMath.max
to ensure the height is non-negative, improving robustness. - Reason this comment was not posted:
Confidence changes required:10%
ThesetSegmentHeight
function now usesMath.max
to ensure the height is non-negative, preventing potential layout issues. This change improves the robustness of the component.
Workflow ID: wflow_dMnsgPYbCzAUwEVZ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This PR removes
chunker_runner
, updatesqdrant-client
to1.13.0
, and refines backend and frontend logic for projects, spans, and workspaces.chunker_runner
frommain.rs
,consumer.rs
, andindex.rs
.create_collection
calls increate_project()
inmod.rs
.qdrant-client
to version1.13.0
inCargo.toml
andCargo.lock
.index_span()
inindex.rs
to directly use content without chunking.Bm25
document length inbm25.rs
to1024.0
.GET
inroute.ts
to fetch workspaces and projects directly from the database.ProjectCard
inproject-card.tsx
to removeCard
component.chat-message-list-tab.tsx
.SpanCard
inspan-card.tsx
.TraceView
intrace-view.tsx
to handle span selection and timeline width.Formatter
informatter.tsx
to handle YAML and JSON modes more robustly.workspace-usage.tsx
.semver
dependency inCargo.toml
andCargo.lock
.This description was created by
for 472e023. It will automatically update as commits are pushed.