Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various qdrant fixes #341

Merged
merged 6 commits into from
Jan 20, 2025
Merged

Various qdrant fixes #341

merged 6 commits into from
Jan 20, 2025

Conversation

dinmukhamedm
Copy link
Member

@dinmukhamedm dinmukhamedm commented Jan 20, 2025

Important

This PR removes chunker_runner, updates qdrant-client to 1.13.0, and refines backend and frontend logic for projects, spans, and workspaces.

  • Backend Changes:
    • Removed chunker_runner from main.rs, consumer.rs, and index.rs.
    • Removed create_collection calls in create_project() in mod.rs.
    • Updated qdrant-client to version 1.13.0 in Cargo.toml and Cargo.lock.
    • Modified index_span() in index.rs to directly use content without chunking.
    • Adjusted Bm25 document length in bm25.rs to 1024.0.
  • Frontend Changes:
    • Updated GET in route.ts to fetch workspaces and projects directly from the database.
    • Modified ProjectCard in project-card.tsx to remove Card component.
    • Adjusted image URL handling in chat-message-list-tab.tsx.
    • Fixed span height calculation in SpanCard in span-card.tsx.
    • Updated TraceView in trace-view.tsx to handle span selection and timeline width.
    • Enhanced Formatter in formatter.tsx to handle YAML and JSON modes more robustly.
    • Updated workspace usage text in workspace-usage.tsx.
  • Miscellaneous:
    • Added semver dependency in Cargo.toml and Cargo.lock.
    • Minor UI adjustments and bug fixes across various frontend components.

This description was created by Ellipsis for 472e023. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 472e023 in 2 minutes and 8 seconds

More details
  • Looked at 665 lines of code in 17 files
  • Skipped 0 files when reviewing.
  • Skipped posting 8 drafted comments based on config settings.
1. app-server/src/main.rs:376
  • Draft comment:
    The removal of chunker_runner from the function call is consistent with the updated logic that no longer requires chunking. Ensure that all related logic is updated accordingly.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The removal of the chunker_runner parameter from the process_queue_spans function and its internal calls is consistent with the removal of the chunking logic from the index_span function. This change simplifies the function signature and aligns with the updated logic that no longer requires chunking.
2. app-server/src/projects/mod.rs:50
  • Draft comment:
    The removal of create_collection calls is consistent with the updated logic that no longer requires these collections. Ensure that all related logic is updated accordingly.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The removal of the create_collection calls in create_project is consistent with the removal of chunking logic. This change simplifies the project creation process and aligns with the updated logic that no longer requires these collections.
3. app-server/src/traces/consumer.rs:11
  • Draft comment:
    The removal of chunker_runner from the function call is consistent with the updated logic that no longer requires chunking. Ensure that all related logic is updated accordingly.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The removal of the chunker_runner parameter from the process_queue_spans function and its internal calls is consistent with the removal of the chunking logic from the index_span function. This change simplifies the function signature and aligns with the updated logic that no longer requires chunking.
4. app-server/src/traces/index.rs:5
  • Draft comment:
    The removal of the chunk function and related logic is consistent with the updated logic that no longer requires chunking. Ensure that all related logic is updated accordingly.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The removal of the chunk function and related logic is consistent with the updated logic that no longer requires chunking. This change simplifies the indexing process and aligns with the updated logic.
5. frontend/app/api/workspaces/route.ts:10
  • Draft comment:
    The GET function now directly queries the database for workspaces and their projects, improving performance and reducing external dependencies.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The GET function now directly queries the database for workspaces and their projects, which is more efficient than the previous approach of fetching from an external API. This change improves performance and reduces external dependencies.
6. frontend/components/projects/project-card.tsx:12
  • Draft comment:
    The ProjectCard component has been simplified by removing the Card component wrapper, reducing complexity and aligning with the updated design.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The ProjectCard component has been simplified by removing the Card component wrapper. This change reduces the complexity of the component and aligns with the updated design.
7. frontend/components/traces/chat-message-list-tab.tsx:34
  • Draft comment:
    The ContentPartImageUrl function now correctly appends ?payloadType=image to relative URLs, ensuring correct handling of images stored in S3.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The ContentPartImageUrl function now correctly appends ?payloadType=image to relative URLs, ensuring that images stored in S3 are correctly identified. This change improves the handling of image URLs.
8. frontend/components/traces/span-card.tsx:47
  • Draft comment:
    The setSegmentHeight function now uses Math.max to ensure the height is non-negative, improving robustness.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The setSegmentHeight function now uses Math.max to ensure the height is non-negative, preventing potential layout issues. This change improves the robustness of the component.

Workflow ID: wflow_dMnsgPYbCzAUwEVZ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@dinmukhamedm dinmukhamedm merged commit da54418 into main Jan 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants