Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't create collections on project create #339

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

skull8888888
Copy link
Collaborator

@skull8888888 skull8888888 commented Jan 20, 2025

Important

Remove creation of semantic search collections in create_project() in mod.rs.

  • Behavior:
    • Removed creation of semantic search collections in create_project() in mod.rs.
    • No longer creates index and spans collections for new projects.
  • Logging:
    • Removed log statements related to collection creation in create_project() in mod.rs.

This description was created by Ellipsis for 030cd7f. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 030cd7f in 8 seconds

More details
  • Looked at 20 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_08zwAJmPxDKgT7t1


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@skull8888888 skull8888888 merged commit ca0a19c into dev Jan 20, 2025
2 checks passed
@skull8888888 skull8888888 deleted the fix/collections branch January 20, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant