Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve inputs number validation #89

Merged
merged 8 commits into from
Dec 21, 2022
Merged

Improve inputs number validation #89

merged 8 commits into from
Dec 21, 2022

Conversation

achampagnedev
Copy link
Contributor

@achampagnedev achampagnedev commented Dec 13, 2022 •
edited by NicolasMahe
Loading

Related: liteflow-labs/liteflow-js#96
Closes #72

This PR has for goal to reimplement the same changes done to the liteflow-js

@achampagnedev achampagnedev self-assigned this Dec 13, 2022
@achampagnedev achampagnedev mentioned this pull request Dec 13, 2022
Merged
18 tasks
@NicolasMahe
Copy link
Member

NicolasMahe commented Dec 14, 2022 •
edited
Loading

I'm putting this PR in draft until liteflow-labs/liteflow-js#96 is merged.
Will be simpler to re-apply the modif once the PR is merged.

Let's actually do the opposite to be able to test easily.

@NicolasMahe NicolasMahe marked this pull request as draft December 14, 2022 08:01
@NicolasMahe NicolasMahe linked an issue Dec 20, 2022 that may be closed by this pull request
Improve validation on NumberInput and NumberInputField #72
Closed
6 tasks
@achampagnedev achampagnedev marked this pull request as ready for review December 20, 2022 08:51
@liteflow-labs liteflow-labs deleted a comment from vercel bot Dec 20, 2022
NicolasMahe
NicolasMahe requested changes Dec 20, 2022
View reviewed changes
Copy link
Member

@NicolasMahe NicolasMahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! A few changes and good to merge

components/Offer/Form/Bid.tsx Outdated Show resolved Hide resolved
components/Offer/Form/Bid.tsx Outdated Show resolved Hide resolved
components/Offer/Summary.tsx Outdated Show resolved Hide resolved
hooks/useParseBigNumber.ts Outdated Show resolved Hide resolved
components/Sales/Direct/Form.tsx Outdated Show resolved Hide resolved
components/Token/Form/Create.tsx Show resolved Hide resolved
pages/explore.tsx Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Dec 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
demo-bsc-testnet 🔄 Building (Inspect) Dec 21, 2022 at 4:06AM (UTC)

@NicolasMahe
Copy link
Member

@achampagnedev Good job, everything works great!

@NicolasMahe NicolasMahe changed the title Feature/number input validation Improve inputs number validation Dec 21, 2022
@NicolasMahe NicolasMahe changed the title Improve inputs number validation Improve inputs number validation Dec 21, 2022
@NicolasMahe NicolasMahe added the bug Something isn't working label Dec 21, 2022
@NicolasMahe NicolasMahe merged commit 6af5e68 into main Dec 21, 2022
@NicolasMahe NicolasMahe deleted the feature/number-input-validation branch December 21, 2022 08:13
@NicolasMahe NicolasMahe mentioned this pull request Dec 21, 2022
Closed
This was referenced Dec 23, 2022
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasMahe NicolasMahe NicolasMahe approved these changes

Assignees

@achampagnedev achampagnedev

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve validation on NumberInput and NumberInputField
2 participants
@achampagnedev @NicolasMahe