Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve validation on NumberInput and NumberInputField #72

Closed
6 tasks
Tracked by #66
NicolasMahe opened this issue Oct 3, 2022 · 0 comments · Fixed by liteflow-labs/liteflow-js#96 or #89
Closed
6 tasks
Tracked by #66

Improve validation on NumberInput and NumberInputField #72

NicolasMahe opened this issue Oct 3, 2022 · 0 comments · Fixed by liteflow-labs/liteflow-js#96 or #89
Assignees
@achampagnedev

Comments

@NicolasMahe
Copy link
Member

NicolasMahe commented Oct 3, 2022 •
edited
Loading

We need to improve constraint on NumberInput and the validation of the NumberInputField:

Screen.Recording.2022-10-03.at.10.25.26.mov

Since https://github.com/liteflow-labs/nft/pull/2024 is merged, we have full control on the validation and can implement more validation in the validate function of react-hook-form.

  • Make sure clampValueOnBlur={false} on all NumberInput
  • Implement the following validation on ALL NumberInputField using react-hook-form:
    • Required if applicable
    • Min value. Can use parseFloat
    • Max value if applicable. Can use parseFloat
    • Precision: use string based validation. No conversion to float
@NicolasMahe NicolasMahe mentioned this issue Dec 12, 2022
Closed
19 tasks
@antho1404 antho1404 transferred this issue from another repository Oct 26, 2022
@antho1404 antho1404 transferred this issue from liteflow-labs/liteflow-js Dec 12, 2022
@achampagnedev achampagnedev mentioned this issue Dec 13, 2022
Merged
18 tasks
@NicolasMahe NicolasMahe mentioned this issue Dec 14, 2022
Merged
@NicolasMahe NicolasMahe linked a pull request Dec 20, 2022 that will close this issue
Improve inputs number validation #89
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@achampagnedev achampagnedev

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@NicolasMahe @achampagnedev