Merge pull request #21 from JonnyOThan/master

Optimize VV rendering
linuxgurugamer · Mar 24, 2023 · e547cd2 · e547cd2
2 parents 4a7d019 + 5df404d
commit e547cd2
Show file tree

Hide file tree

Showing 8 changed files with 370 additions and 411 deletions.
diff --git a/VVPartSelector/VViewMenuPartSelectorGlobal.cs b/VVPartSelector/VViewMenuPartSelectorGlobal.cs
@@ -100,7 +100,7 @@ private void AppendRichTextLine(StringBuilder builder, string richText)
             builder.AppendLine();
         }
 
-        public void printMenu(ref StringBuilder builder, int width, int height)
+        public void printMenu(StringBuilder builder, int width, int height)
         {
             //MonoBehaviour.print("scroll:"+scrollOffset);
             int linesPrinted = 1;

diff --git a/VVPartSelector/VViewMenuPartSelectorTree.cs b/VVPartSelector/VViewMenuPartSelectorTree.cs
@@ -58,7 +58,7 @@ public Part getSelection()
             return tree.selectedItem.associatedPart;
         }
 
-        public void printMenu(ref StringBuilder builder, int width, int height)
+        public void printMenu(StringBuilder builder, int width, int height)
         {
 
 

diff --git a/VVPartSelector/VVsinglePartSubmenu.cs b/VVPartSelector/VVsinglePartSubmenu.cs
@@ -26,7 +26,7 @@ internal VVsinglePartSubmenu(SelectorDataContainer master, String action)
             this.name = action;
         }
 
-        public void printMenu(ref StringBuilder builder, int width, int height)
+        public void printMenu(StringBuilder builder, int width, int height)
         {
             //MonoBehaviour.print("scroll:"+scrollOffset);
             int linesPrinted = 1;

diff --git a/VesselView/VesselViewer.cs b/VesselView/VesselViewer.cs
diff --git a/VesselViewRPM/InternalVesselView.cs b/VesselViewRPM/InternalVesselView.cs
@@ -84,15 +84,17 @@ class InternalVesselView : InternalModule
         private bool forceRedraw = false;
         private bool textChanged = false;
 
+        StringBuilder builder = new StringBuilder();
+
         public string ShowMenu(int width, int height)
         {
             //MonoBehaviour.print("text draw call");           
-            StringBuilder builder = new StringBuilder();
+            builder.Clear();
             builder.AppendLine(pageTitle);
 
             if (activeMenu != null) {
                 IVViewMenu outMenu = activeMenu.update(FlightGlobals.ActiveVessel);
-                if (outMenu == null) activeMenu.printMenu(ref builder, width, height);
+                if (outMenu == null) activeMenu.printMenu(builder, width, height);
                 else activeMenu = outMenu;
             }
             //MonoBehaviour.print("text draw call done");

diff --git a/VesselViewRPM/menus/IVViewMenu.cs b/VesselViewRPM/menus/IVViewMenu.cs
@@ -8,7 +8,7 @@ namespace VesselViewRPM.menus
 {
     public interface IVViewMenu
     {
-        void printMenu(ref StringBuilder builder, int width, int height);
+        void printMenu(StringBuilder builder, int width, int height);
 
         void up();
         void down();

diff --git a/VesselViewRPM/menus/VViewCustomMenusMenu.cs b/VesselViewRPM/menus/VViewCustomMenusMenu.cs
@@ -38,7 +38,7 @@ public static void registerMenu(Func<IVViewMenu> createInstance)
             menuMakerList.Add(createInstance);
         }
 
-        public void printMenu(ref StringBuilder builder, int width, int height)
+        public void printMenu(StringBuilder builder, int width, int height)
         {
             builder.Append("-|");
             builder.Append(name);

diff --git a/VesselViewRPM/menus/VViewSimpleMenu.cs b/VesselViewRPM/menus/VViewSimpleMenu.cs
@@ -28,7 +28,7 @@ public VViewSimpleMenu(IVVSimpleMenuItem[] items, string name)
             this.name = name;
         }
 
-        public void printMenu(ref StringBuilder builder, int width, int height)
+        public void printMenu(StringBuilder builder, int width, int height)
         {
             builder.Append("-|");
             builder.Append(name);