Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-7887] - VPC Not Recommended Configuration Tooltip Text Revision #11098

Merged
merged 43 commits into from
Oct 15, 2024

Conversation

cpathipa
Copy link
Contributor

Description 📝

This PR updates the revised tooltip copy in SubnetLinodeRow component. Tooltips that contain anchor tags linking to external documents are not accessible. Hence anchor tag is removed.

Changes 🔄

List any change relevant to the reviewer.

  • Removed anchor tag from tooltip text in SubnetLinodeRow
  • Removed NETWORK_INTERFACES_GUIDE_URL url since it is not used any more.

Target release date 🗓️

10/28

Preview 📷

Before After
image image

How to test 🧪

Verification steps

(How to verify changes)

  • Navigate to vpc subnet details page
  • Expand subnet with linode that has unrecommended configurations
  • Verify the copy and confirm anchor tag removal.
  • Confirm no regression.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@cpathipa cpathipa self-assigned this Oct 14, 2024
@cpathipa cpathipa requested a review from a team as a code owner October 14, 2024 20:40
@cpathipa cpathipa requested review from mjac0bs and hkhalil-akamai and removed request for a team October 14, 2024 20:40
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chandra, looks good pending tests pass. I left some minor feedback.

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Oct 14, 2024
Copy link

github-actions bot commented Oct 14, 2024

Coverage Report:
Base Coverage: 86.96%
Current Coverage: 86.96%

@harsh-akamai harsh-akamai self-requested a review October 15, 2024 08:57
Copy link
Contributor

@harsh-akamai harsh-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! PR looks good 👍

@harsh-akamai harsh-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Oct 15, 2024
cpathipa and others added 2 commits October 15, 2024 09:30
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
@cpathipa cpathipa merged commit 4fd4376 into linode:develop Oct 15, 2024
21 of 23 checks passed
Copy link

cypress bot commented Oct 15, 2024

Cloud Manager E2E    Run #6675

Run Properties:  status check failed Failed #6675  •  git commit 4fd4376e8a: change: [M3-7887] - VPC Not Recommended Configuration Tooltip Text Revision (#11...
Project Cloud Manager E2E
Run status status check failed Failed #6675
Run duration 30m 35s
Commit git commit 4fd4376e8a: change: [M3-7887] - VPC Not Recommended Configuration Tooltip Text Revision (#11...
Committer cpathipa
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 7
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 433

Tests for review

Failed  oneClickApps/one-click-apps.spec.ts • 1 failed test

View Output Video

Test Artifacts
OneClick Apps (OCA) > Lists all the OneClick Apps Screenshots Video
Failed  helpAndSupport/open-support-ticket.spec.ts • 1 failed test

View Output Video

Test Artifacts
open support tickets > can create an SMTP support ticket Screenshots Video
Flakiness  linodes/linode-config.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Linode Config management > End-to-End > Clones a config Screenshots Video
Flakiness  linodes/clone-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video
Flakiness  linodes/rebuild-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
rebuild linode > cannot rebuild a provisioning linode Screenshots Video
Flakiness  placementGroups/delete-placement-groups.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Placement Group deletion > can delete with Linodes assigned when unexpected error show up and retry Screenshots Video
Flakiness  objectStorageGen2/bucket-create-gen2.spec.ts • 2 flaky tests

View Output Video

Test Artifacts
Object Storage Gen2 create bucket tests > can create a bucket with E1 endpoint type Screenshots Video
Object Storage Gen2 create bucket tests > can create a bucket with E3 endpoint type Screenshots Video

The first 5 flaky specs are shown, see all 6 specs in Cypress Cloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants