chore: [M3-8662] - Update Github Actions actions #11009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
added
the
Dependencies
bnussman-akamai
requested review from
dwiley-akamai and
abailly-akamai
and removed request for
a team
bnussman-akamai
commented
Sep 26, 2024
Comment on lines
-122
to
-125
| path: | | ||
| packages/api-v4/index.js | ||
| packages/api-v4/index.node.js | ||
| packages/api-v4/lib |
There was a problem hiding this comment.
packages/api-v4/index.js and packages/api-v4/index.node.js have not existed since #8484 was merged ages ago. All of the build artifacts for validation and api-v4 are in the lib folder. This PR cleans up this to prevent confusion going forward
Comment on lines
-47
to
-49
| path: | | ||
| packages/validation/index.js | ||
| packages/validation/lib |
There was a problem hiding this comment.
Refer to the comment on the similar change for api-v4
|
Coverage Report: ✅ |
abailly-akamai
approved these changes
Sep 26, 2024
dwiley-akamai
approved these changes
Sep 26, 2024
| uses: actions/deploy-pages@v4 |
There was a problem hiding this comment.
Did we miss a previous version jump for this and actions/configure-pages?
There was a problem hiding this comment.
Maybe. I'm guessing we may have built this Github Action from a guide somewhere online and maybe it didn't have the most up-to-date versions being used
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 25m 56s |
| Commit |
|
| Committer | Banks Nussman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
408
|
| View all changes introduced in this branch ↗︎ | |
cpathipa
pushed a commit
to cpathipa/manager
that referenced
this pull request
Sep 30, 2024
* update actions * add changeset --------- Co-authored-by: Banks Nussman <banks@nussman.us>
12 tasks
This was referenced Oct 10, 2024
cpathipa
added a commit
that referenced
this pull request
Oct 15, 2024
…vision (#11098) * unit test coverage for HostNameTableCell * Revert "unit test coverage for HostNameTableCell" This reverts commit b274baf. * chore: [M3-8662] - Update Github Actions actions (#11009) * update actions * add changeset --------- Co-authored-by: Banks Nussman <banks@nussman.us> * update revised copy * Added changeset: VPC Not Recommended Configuration Tooltip Text Revision * Update packages/manager/.changeset/pr-11098-changed-1728938497573.md Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Update packages/manager/src/features/VPCs/VPCDetail/SubnetLinodeRow.tsx Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> --------- Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com> Co-authored-by: Banks Nussman <banks@nussman.us> Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
cpathipa
added a commit
that referenced
this pull request
Oct 17, 2024
…roperly (#11074) * unit test coverage for HostNameTableCell * Revert "unit test coverage for HostNameTableCell" This reverts commit b274baf. * chore: [M3-8662] - Update Github Actions actions (#11009) * update actions * add changeset --------- Co-authored-by: Banks Nussman <banks@nussman.us> * fix: [M3-7197] - "Support Ticket" button in network tab not working properly * Create pr-11074-fixed-1728476792585.md --------- Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com> Co-authored-by: Banks Nussman <banks@nussman.us>
cpathipa
added a commit
that referenced
this pull request
Oct 17, 2024
…ng the main search tool. (#11112) * unit test coverage for HostNameTableCell * Revert "unit test coverage for HostNameTableCell" This reverts commit b274baf. * chore: [M3-8662] - Update Github Actions actions (#11009) * update actions * add changeset --------- Co-authored-by: Banks Nussman <banks@nussman.us> * Add capability to search linode by id from main search tool * Added changeset: Add the capability to search for a Linode by ID using the main search tool. * Update packages/manager/.changeset/pr-11112-added-1729086990373.md Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Update packages/manager/cypress/e2e/core/linodes/search-linodes.spec.ts Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> --------- Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com> Co-authored-by: Banks Nussman <banks@nussman.us> Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
api-v4andvalidationassets 📦Preview 📷
ci.ymlon developci.ymlon this PRHow to test 🧪
As an Author I have considered 🤔