-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [UIE-8002] - DBaaS 2.0 Landing Page #10823
feat: [UIE-8002] - DBaaS 2.0 Landing Page #10823
Conversation
packages/manager/src/features/Databases/DatabaseLanding/DatabaseLogo.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseLanding/DatabaseLandingEmptyStateData.tsx
Outdated
Show resolved
Hide resolved
@mpolotsk-akamai I just merged in #10786 so we'll want to rebase this PR on |
a837c8e
to
ea91214
Compare
@mjac0bs , thanks, I've rebased the PR |
packages/manager/src/features/Databases/DatabaseLanding/DatabaseLanding.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseLanding/DatabaseLanding.test.tsx
Outdated
Show resolved
Hide resolved
Coverage Report: ✅ |
8fee671
to
a77a2ec
Compare
packages/manager/src/features/Support/SupportTickets/SupportTicketProductSelectionFields.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Support/SupportTickets/SupportTicketProductSelectionFields.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseLanding/DatabaseLandingTable.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/EmptyLandingPageResources/ResourcesLinksTypes.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseLanding/DatabaseLanding.test.tsx
Show resolved
Hide resolved
packages/manager/src/features/GlobalNotifications/DatabaseClusterInfoBanner.tsx
Outdated
Show resolved
Hide resolved
a77a2ec
to
f615f52
Compare
4952395
to
6962afe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing feedback, @mpolotsk-akamai - I just left a couple of minor notes on my final pass through.
CI was struggling to run the full e2e suite but I'll make sure DBaaS is all passing before this gets merged.
packages/manager/src/features/Databases/DatabaseLanding/DatabaseLogo.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseLanding/DatabaseLanding.tsx
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseLanding/DatabaseRow.tsx
Outdated
Show resolved
Hide resolved
@mpolotsk-akamai Just noticed that typecheck is was failing - using the optional chaining operator to access databases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is shaping up nicely! Will continue to review, but left a few more small comments in the meantime
packages/manager/src/features/Databases/DatabaseLanding/DatabaseRow.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseLanding/DatabaseRow.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseLanding/DatabaseLandingTable.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseLanding/DatabaseLanding.tsx
Show resolved
Hide resolved
6962afe
to
910e0df
Compare
910e0df
to
87ba377
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/manager/src/features/Databases/DatabaseLanding/DatabaseLanding.tsx
Show resolved
Hide resolved
87ba377
to
c703764
Compare
c703764
to
bac6623
Compare
bac6623
to
92369fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to call out the failing Cypress tests in create-database.spec.ts
so we don't accidentally merge this before they're fixed.
It looks like the tests are failing because no regions are appearing in the region select drop-down -- that's probably caused by something not being mocked
ee35a62
to
f4683a8
Compare
@jdamore-linode, I've fixed the issue. |
Nice! Thanks @mpolotsk-akamai! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @mpolotsk-akamai!
packages/manager/src/features/Databases/DatabaseLanding/DatabaseLanding.tsx
Outdated
Show resolved
Hide resolved
f4683a8
to
c3460e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mpolotsk-akamai and @corya-akamai - looking good now. I'll merge this as soon as CI finishes.
* feat: [UIE-8054] - DBaaS enhancements 1 * UIE-8002 feat(DBaaS): New/Existing Customer Landing Page * UIE-8002 feat(DBaaS): Landing Page with feature flag * Added changeset: Add Landing Page for V2 * Added changeset: Add Landing Page and update Empty-State Landing page for DBaaS V2 * feat: [UIE-8002] - Review fix: refactoring and variable renaming * feat: [UIE-8002] - Review fix: change capability for region select --------- Co-authored-by: Conal Ryan <corya@akamai.com>
Description 📝
DBaaS 2.0 Landing Page and Empty Landing Page
Changes 🔄
Target release date 🗓️
9/9/24
Preview 📷
Include a screenshot or screen recording of the change
💡 Use
<video src="" />
tag when including recordings in table.How to test 🧪
Note:
To test all beta features, beta must be enabled, and the user must have the "Managed Databases Beta" account capability.
Prerequisites
(How to setup test environment)
Enable DatabaseV2Beta flag
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply