-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [UIE-8054] - DBaaS enhancements 1 #10786
feat: [UIE-8054] - DBaaS enhancements 1 #10786
Conversation
@corya-akamai I have a general question, should we control this feature using both a feature flag and a capability check? Currently, we don't have a mechanism to disable these new additions or roll them back since we're only considering the capability. I believe it would be beneficial to continue using the feature flag in conjunction with the capability, for which we have an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @corya-akamai!
I'm in agreement with Jaalah about it being beneficial to be able to control this with a LD feature flag, as well.
Noting that we've got a unit test failure on DatabaseResizeCurrentConfiguration.test.tsx
(can replicate this with yarn test DatabaseResizeCurrentConfiguration
) because of changes to the mocks. It looks like types are impacting the databaseTypeFactory
's vcpus in the test.
packages/manager/src/features/Databases/DatabaseLanding/DatabaseLogo.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseLanding/DatabaseLogo.tsx
Outdated
Show resolved
Hide resolved
Thanks, I've updated the tests. We have a DBaaS meeting today, I'll ask about adding a feature flag. Added the dbaasV2 feature flag thanks @mjac0bs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving pending: the couple of fixes to get the unit tests passing and the changeset update. This is looking good otherwise.
...features/Databases/DatabaseDetail/DatabaseResize/DatabaseResizeCurrentConfiguration.test.tsx
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseCreate/DatabaseCreate.tsx
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseLanding/DatabaseLogo.tsx
Outdated
Show resolved
Hide resolved
Coverage Report: ✅ |
packages/manager/src/features/Support/SupportTickets/SupportTicketProductSelectionFields.tsx
Outdated
Show resolved
Hide resolved
@corya-akamai I'll merge this as soon as CI finishes. (The one CI failure on a stackscripts test is expected and unrelated.) |
Description 📝
Common changes for the V2 enhancements that will be used in create/landing/detail flows
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
9/3/24
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply
Commit message and pull request title format standards
<commit type>: [JIRA-ticket-number] - <description>
Commit Types:
feat
: New feature for the user (not a part of the code, or ci, ...).fix
: Bugfix for the user (not a fix to build something, ...).change
: Modifying an existing visual UI instance. Such as a component or a feature.refactor
: Restructuring existing code without changing its external behavior or visual UI. Typically to improve readability, maintainability, and performance.test
: New tests or changes to existing tests. Does not change the production code.upcoming
: A new feature that is in progress, not visible to users yet, and usually behind a feature flag.Example:
feat: [M3-1234] - Allow user to view their login history