Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [UIE-8054] - DBaaS enhancements 1 #10786

Merged
merged 8 commits into from
Aug 23, 2024

Conversation

corya-akamai
Copy link
Contributor

@corya-akamai corya-akamai commented Aug 14, 2024

Description 📝

Common changes for the V2 enhancements that will be used in create/landing/detail flows

Changes 🔄

List any change relevant to the reviewer.

  • Adding capability to accounts and regions
  • Check for either capability to show menu item
  • Use V2 to add Beta flag
  • Add additional factory data to test flows

Target release date 🗓️

9/3/24

How to test 🧪

Prerequisites

(How to setup test environment)

  • Add V2 capability to account factory mocks

Verification steps

(How to verify changes)

  • Beta chip shows for V2 capability

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

Commit message and pull request title format standards

Note: Remove this section before opening the pull request
Make sure your PR title and commit message on squash and merge are as shown below

<commit type>: [JIRA-ticket-number] - <description>

Commit Types:

  • feat: New feature for the user (not a part of the code, or ci, ...).
  • fix: Bugfix for the user (not a fix to build something, ...).
  • change: Modifying an existing visual UI instance. Such as a component or a feature.
  • refactor: Restructuring existing code without changing its external behavior or visual UI. Typically to improve readability, maintainability, and performance.
  • test: New tests or changes to existing tests. Does not change the production code.
  • upcoming: A new feature that is in progress, not visible to users yet, and usually behind a feature flag.

Example: feat: [M3-1234] - Allow user to view their login history


@corya-akamai corya-akamai requested a review from a team as a code owner August 14, 2024 18:55
@corya-akamai corya-akamai requested review from mjac0bs and hana-akamai and removed request for a team August 14, 2024 18:55
@jaalah-akamai
Copy link
Contributor

jaalah-akamai commented Aug 14, 2024

@corya-akamai I have a general question, should we control this feature using both a feature flag and a capability check? Currently, we don't have a mechanism to disable these new additions or roll them back since we're only considering the capability. I believe it would be beneficial to continue using the feature flag in conjunction with the capability, for which we have an isFeatureEnabledV2 utility that you can utilize. Just something to think about

@mjac0bs mjac0bs added the DBaaS Relates to Database as a Service label Aug 15, 2024
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @corya-akamai!

I'm in agreement with Jaalah about it being beneficial to be able to control this with a LD feature flag, as well.

Noting that we've got a unit test failure on DatabaseResizeCurrentConfiguration.test.tsx (can replicate this with yarn test DatabaseResizeCurrentConfiguration) because of changes to the mocks. It looks like types are impacting the databaseTypeFactory's vcpus in the test.

@corya-akamai
Copy link
Contributor Author

corya-akamai commented Aug 16, 2024

Thanks for the contribution @corya-akamai!

I'm in agreement with Jaalah about it being beneficial to be able to control this with a LD feature flag, as well.

Noting that we've got a unit test failure on DatabaseResizeCurrentConfiguration.test.tsx (can replicate this with yarn test DatabaseResizeCurrentConfiguration) because of changes to the mocks. It looks like types are impacting the databaseTypeFactory's vcpus in the test.

Thanks, I've updated the tests. We have a DBaaS meeting today, I'll ask about adding a feature flag.

Added the dbaasV2 feature flag thanks @mjac0bs

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving pending: the couple of fixes to get the unit tests passing and the changeset update. This is looking good otherwise.

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Aug 20, 2024
Copy link

github-actions bot commented Aug 22, 2024

Coverage Report:
Base Coverage: 82.63%
Current Coverage: 82.63%

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 23, 2024
@mjac0bs
Copy link
Contributor

mjac0bs commented Aug 23, 2024

@corya-akamai I'll merge this as soon as CI finishes. (The one CI failure on a stackscripts test is expected and unrelated.)

@mjac0bs mjac0bs merged commit b665964 into linode:develop Aug 23, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! DBaaS Relates to Database as a Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants