feat: [M3-8017] - Support Linodes in Distributed Compute Regions on Image Create #10544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
changed the title
… Linode in a distributed compute region
bnussman-akamai
requested review from
dwiley-akamai and
cpathipa
and removed request for
a team
bnussman-akamai
commented
Jun 4, 2024
| await findByText('Image scheduled for creation.'); | ||
| }); | ||
|
|
||
| it('should render a notice if the user selects a Linode in a distributed compute region', async () => { |
There was a problem hiding this comment.
Unit test for this PR's addition
| ); | ||
| }); | ||
|
|
||
| it('should render an encryption notice if disk encryption is enabled and the Linode is not in a distributed compute region', async () => { |
There was a problem hiding this comment.
Unit test for @dwiley-akamai 's change in #10521
There was a problem hiding this comment.
Oops, I just realized you covered this in a cypress test already. I'll keep it here anyway unless there are any objections.
hkhalil-akamai
approved these changes
Jun 6, 2024
| This Linode is in a distributed compute region. Images captured | ||
| from this Linode will be stored in the closest core site. | ||
| </Notice> | ||
| )} |
There was a problem hiding this comment.
Can we increase the margins above and below this notice to match the mockups?
| This PR | Figma mockup |
|---|---|
 |
 |
There was a problem hiding this comment.
I increased overall spacing in ba513a7, let me know if that looks okay to you! 👁️
There was a problem hiding this comment.
Thanks for adding unit tests for this component! 🙌🏽
|
Coverage Report: ✅ |
cpathipa
approved these changes
Jun 11, 2024
bnussman-akamai
added
Approved
This was referenced Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This Linode is in a distributed compute region. Images captured from this Linode will be stored in the closest core site.if you select a Linode that is in a distributed region on the Image Create page ℹ️Image will be stored in the closest core site to (us-den-edge-1)below the Linode select if the selected Linode is in a distributed region ℹ️These changes are based on the Image Service Gen2 Figma wireframes 🎨 - Ask me for a link if you want to reference it.
Preview 📷
How to test 🧪
Prerequisites
Verification steps
As an Author I have considered 🤔