upcoming: [M3-8139, M3-8140, M3-8141] – Add warning notices re: non-encryption when creating Images & enabling Backups #10521
Conversation
| .click(); | ||
|
|
||
| // Check if notice is visible | ||
| cy.get(`[data-testid=${encryptionCaveatNoticeTestId}]`).should('exist'); |
There was a problem hiding this comment.
In a hypothetical scenario where this warning notice fails to appear or the language inadvertently gets changed, is there any risk a customer could create an Image and expect it to be encrypted and suffer some kind of incident as a result?
If we're not certain the answer is no, I might suggest searching for the actual contents of the notice (i.e. via cy.findByText('...')), and I might additionally suggest that we define a constant in this spec containing that language (not importing the const from src) so that this test fails if the language is ever inadvertently changed or fails to render inside the data-testid="encryption-caveat-notice" element.
There was a problem hiding this comment.
I don't think there would be any risk of them suffering an incident since there's currently no ability for a user to choose to encrypt an image, but down the line it is possible some users may assume that all resources get encrypted after being conditioned by LDE.
That is a reasonable adjustment though, included it in the most recent commit 🚀 Thanks for taking a look and for the suggestions!
…eating Images and enabling Backups
…bleBackupsDialog and LDE-related E2E assertions for Create Image flow
| @@ -123,9 +149,9 @@ export const CreateImageTab = () => { | |||
| text="open a support ticket" | |||
| title="Request to increase Image size limit when capturing from Linode disk" | |||
| />{' '} | |||
| to request a higher limit. Additionally, images can't be created | |||
| from a raw disk or a disk that's formatted using a custom file | |||
| system. | |||
There was a problem hiding this comment.
prompted by linter -- small change to use apostrophe as we do in other places throughout the app instead of the single quotation mark
|
|
||
| const { data: linode } = useLinodeQuery( | ||
| selectedLinodeId ?? -1, | ||
| Boolean(selectedLinodeId) && isDiskEncryptionFeatureEnabled |
There was a problem hiding this comment.
the objective here is prevent this query from firing off constantly if a linode hasn't been selected yet or if LDE is not enabled
dwiley-akamai
requested review from
AzureLatte,
hana-akamai and
hkhalil-akamai
and removed request for
a team
|
Coverage Report: ✅ |
Description 📝
Add notices to the Imagize dialog, "Enable Backups" dialog, and the Create Image --> "Capture Image" tab advising users that Images and Backups are not encrypted.
Target release date 🗓️
6/10
Preview 📷
Screenshots
How to test 🧪
Prerequisites
linode_disk_encryptiontag on your accountLinode Disk Encryption (LDE)flag in our dev tool toggled onVerification steps
Without the tag and/or with the LDE flag in our dev tool toggled off, you should not see any LDE-related things in the UI. Otherwise,
The last item is a bit difficult to test at the moment outside of DevEnv, but you can turn the MSW on and first select
metadata-test-imageto see the notice and then switch to the next two (metadata-test-regionandGecko Edge Test) to see that it doesn't appear. Nonetheless, thelinodeIsInEdgeRegionlogic inCreateImageTab.tsxshould ensure that the notice is not displayed if the selected linode is in an Edge region.As an Author I have considered 🤔