Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-7784] - Cypress integration tests for Placement Group update label flow #10529

Merged
merged 4 commits into from
Jun 3, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-10529-tests-1717072137790.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Tests
---

Cypress integration tests for PG update label flow ([#10529](https://github.com/linode/manager/pull/10529))
Original file line number Diff line number Diff line change
@@ -0,0 +1,153 @@
/**
* @file Integration tests for Placement Group update label flows.
*/

import {
mockAppendFeatureFlags,
mockGetFeatureFlagClientstream,
} from 'support/intercepts/feature-flags';
import { makeFeatureFlagData } from 'support/util/feature-flags';
import { randomLabel, randomNumber } from 'support/util/random';
import {
mockGetPlacementGroups,
mockUpdatePlacementGroupLabel,
mockUpdatePlacementGroupLabelError,
} from 'support/intercepts/placement-groups';
import { accountFactory, placementGroupFactory } from 'src/factories';
import { mockGetAccount } from 'support/intercepts/account';
import { authenticate } from 'support/api/authentication';
mjac0bs marked this conversation as resolved.
Show resolved Hide resolved
import type { Flags } from 'src/featureFlags';
import { chooseRegion } from 'support/util/regions';
import { ui } from 'support/ui';
import type { UpdatePlacementGroupPayload } from '@linode/api-v4';

const mockAccount = accountFactory.build();
authenticate();
mjac0bs marked this conversation as resolved.
Show resolved Hide resolved

describe('Placement Group update label flow', () => {
// Mock the VM Placement Groups feature flag to be enabled for each test in this block.
beforeEach(() => {
mockAppendFeatureFlags({
placementGroups: makeFeatureFlagData<Flags['placementGroups']>({
beta: true,
enabled: true,
}),
});
mockGetFeatureFlagClientstream();
mockGetAccount(mockAccount).as('getAccount');
mjac0bs marked this conversation as resolved.
Show resolved Hide resolved
});

/**
* - Confirms that a Placement Group's label can be updated from the landing page.
* - Confirms that clicking "Edit" opens PG edit drawer.
* - Only the label field is shown in the edit drawer.
* - New label can be entered into the label field.
* - Confirms that Placement Groups landing page updates to reflect successful label update.
carrillo-erik marked this conversation as resolved.
Show resolved Hide resolved
* - Confirms a toast notification is shown upon successful label update.
*/
it("update to a Placement Group's label is successful", () => {
const mockPlacementGroupCompliantRegion = chooseRegion();

const mockPlacementGroup = placementGroupFactory.build({
id: randomNumber(),
label: randomLabel(),
region: mockPlacementGroupCompliantRegion.id,
affinity_type: 'anti_affinity:local',
is_compliant: true,
is_strict: false,
members: [],
});

const newLabel: UpdatePlacementGroupPayload = {
label: randomLabel(),
};
carrillo-erik marked this conversation as resolved.
Show resolved Hide resolved

mockGetPlacementGroups([mockPlacementGroup]).as('getPlacementGroups');

mockUpdatePlacementGroupLabel(mockPlacementGroup.id, newLabel).as(
'updatePlacementGroupLabel'
);

cy.visitWithLogin('/placement-groups');
cy.wait(['@getPlacementGroups']);

// Confirm that compliant Placement Group is listed on landing page, click "Edit" to open drawer.
cy.findByText(mockPlacementGroup.label)
.should('be.visible')
.closest('tr')
.within(() => {
cy.findByText('Edit').click();
});

// Enter new label, click "Edit".
cy.get('[data-qa-drawer="true"]').within(() => {
cy.findByText('Edit').should('be.visible');
cy.findByDisplayValue(mockPlacementGroup.label)
.should('be.visible')
.click()
.type(`{selectall}{backspace}${newLabel.label}`);

cy.findByText('Edit').should('be.visible').click();

cy.wait('@updatePlacementGroupLabel').then((intercept) => {
expect(intercept.request.body['label']).to.equal(newLabel.label);
});
});

ui.toast.assertMessage(
`Placement Group ${newLabel.label} successfully updated.`
);
});

it("update to a Placement Group's label fails", () => {
mjac0bs marked this conversation as resolved.
Show resolved Hide resolved
const mockPlacementGroupCompliantRegion = chooseRegion();

const mockPlacementGroup = placementGroupFactory.build({
id: randomNumber(),
label: randomLabel(),
region: mockPlacementGroupCompliantRegion.id,
affinity_type: 'anti_affinity:local',
is_compliant: true,
is_strict: false,
members: [],
});

const newLabel: UpdatePlacementGroupPayload = {
label: randomLabel(),
};

mockGetPlacementGroups([mockPlacementGroup]).as('getPlacementGroups');

mockUpdatePlacementGroupLabelError(
mockPlacementGroup.id,
'An unexpected error occurred.',
400
).as('updatePlacementGroupLabelError');

cy.visitWithLogin('/placement-groups');
cy.wait(['@getPlacementGroups']);

// Confirm that compliant Placement Group is listed on landing page, click "Edit" to open drawer.
cy.findByText(mockPlacementGroup.label)
.should('be.visible')
.closest('tr')
.within(() => {
cy.findByText('Edit').click();
});

// Enter new label, click "Edit".
cy.get('[data-qa-drawer="true"]').within(() => {
cy.findByText('Edit').should('be.visible');
cy.findByDisplayValue(mockPlacementGroup.label)
.should('be.visible')
.click()
.type(`{selectall}{backspace}${newLabel.label}`);

cy.findByText('Edit').should('be.visible').click();

// Confirm error message is displayed in the drawer.
cy.wait('@updatePlacementGroupLabelError');
cy.findByText('An unexpected error occurred.').should('be.visible');
});
});
});
50 changes: 48 additions & 2 deletions packages/manager/cypress/support/intercepts/placement-groups.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
import { makeErrorResponse } from 'support/util/errors';
import { apiMatcher } from 'support/util/intercepts';
import { paginateResponse } from 'support/util/paginate';
import type { PlacementGroup } from '@linode/api-v4';
import { makeResponse } from 'support/util/response';
import { makeErrorResponse } from 'support/util/errors';

import type {
PlacementGroup,
UpdatePlacementGroupPayload,
} from '@linode/api-v4';

/**
* Intercepts GET request to fetch Placement Groups and mocks response.
Expand Down Expand Up @@ -175,3 +179,45 @@ export const mockDeletePlacementGroupError = (
makeErrorResponse(errorMessage, errorCode)
);
};

/**
* Intercepts PUT request to update Placement Group label and mocks response.
*
* @param placementGroupId - ID of Placement Group for which to intercept update label request.
* @param placementGroupData - Placement Group object with which to mock response.
*
* @returns Cypress chainable.
*/
export const mockUpdatePlacementGroupLabel = (
carrillo-erik marked this conversation as resolved.
Show resolved Hide resolved
placementGroupId: number,
placementGroupData: UpdatePlacementGroupPayload
): Cypress.Chainable<null> => {
return cy.intercept(
'PUT',
apiMatcher(`placement/groups/${placementGroupId}`),
makeResponse(placementGroupData)
);
};

/**
* Intercepts PUT request to update Placement Group label and mocks HTTP error response.
*
* By default, a 500 response is mocked.
*
* @param placementGroupId - ID of Placement Group for which to intercept update label request.
* @param errorMessage - Optional error message with which to mock response.
* @param errorCode - Optional error code with which to mock response. Default is `500`.
*
* @returns Cypress chainable.
*/
export const mockUpdatePlacementGroupLabelError = (
placementGroupId: number,
errorMessage: string = 'An error has occurred',
errorCode: number = 500
): Cypress.Chainable<null> => {
return cy.intercept(
'PUT',
apiMatcher(`placement/groups/${placementGroupId}`),
makeErrorResponse(errorMessage, errorCode)
);
};
Loading