Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-7784] - Cypress integration tests for Placement Group update label flow #10529

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

carrillo-erik
Copy link
Contributor

@carrillo-erik carrillo-erik commented May 30, 2024

Description 📝

This adds Cypress integration tests for the Placement Group update label flow via Placement Group's landing page.

Changes 🔄

List any change relevant to the reviewer.

  • Two new mocking functions for the label update flow: mockUpdatePlacementGroupLabel() and mockUpdatePlacementGroupLabelError()

Target release date 🗓️

06/10/2024

How to test 🧪

Prerequisites

  • Check this branch out and run
yarn cy:run -s "cypress/e2e/core/placementGroups/update-placement-group-label.spec.ts"
  • Or you can run the tests in debug mode by running yarn cy:debug.

Verification steps

(How to verify changes)

  • Verify that all tests are passing.
  • Validate that the flows and assertions covered by these changes are adequate.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@carrillo-erik carrillo-erik self-assigned this May 30, 2024
@carrillo-erik carrillo-erik requested a review from a team as a code owner May 30, 2024 12:15
@carrillo-erik carrillo-erik requested review from jdamore-linode and removed request for a team May 30, 2024 12:15
@carrillo-erik carrillo-erik requested a review from a team as a code owner May 30, 2024 12:29
@carrillo-erik carrillo-erik requested review from mjac0bs and AzureLatte and removed request for a team May 30, 2024 12:29
Copy link

github-actions bot commented May 30, 2024

Coverage Report:
Base Coverage: 82.34%
Current Coverage: 82.34%

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @carrillo-erik! Posted a couple suggestions involving the mocks and your comment, but the tests themselves are looking really good! Ping me once you make any changes and I'd be happy to re-review!

Copy link
Contributor

@AzureLatte AzureLatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the updates @carrillo-erik! Looks (and runs) great!

@abailly-akamai
Copy link
Contributor

Thanks for handling this one!

Test coverage is good ✅
Test pass ✅

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Erik, test looks good and you've got the approvals - I just noticed a few small bits of clean up that could be addressed.

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Work in Progress labels Jun 3, 2024
@carrillo-erik carrillo-erik merged commit 8545f68 into linode:develop Jun 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Placement Groups Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants