fix: [M3-7739, M3-7741, M3-7746, M3-7747] - Cherry pick zero price fixes for release #10177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Add a Node Pool drawers (linode#10157) * Allow -zsh LKE prices without error notices in Resize Pool and Add Pool drawers * Fix loading spinner displaying above what was supposed to be loading * Fix conditional to render notice if either price is invalid * Add test coverage * Added changeset: Hide error notices for /bin/sh regions for LKE Resize and Add Node Pools * Fix changeset wording * Address feedback: use invalid price util
…awer (linode#10161) * Remove error indicator for Linodes in $0 regions * Fix $0 total price display issue * Cover $0 pricing cases in Cypress backup tests * Add BackupLinodeRow tests to account for error states and $0 regions * Add unit tests for BackupDrawer component
…10166) * Add unit tests for MigrationPricing component * Accounting for $0 prices in MigrationPricing component
…ns with $0 price (linode#10153) * Fix error when enabling backups for Linodes in regions with $0 price * Add unit tests for EnableBackupsDialog --------- Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
jdamore-linode
requested review from
cliu-akamai,
cpathipa and
abailly-akamai
and removed request for
a team
mjac0bs
reviewed
Feb 12, 2024
mjac0bs
approved these changes
Feb 12, 2024
cpathipa
approved these changes
Feb 12, 2024
hana-akamai
approved these changes
Feb 12, 2024
jdamore-linode
merged commit 9d5fad5
into
linode:staging-off-release
16 of 17 checks passed
|
Coverage Report: ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Eliminates errors displayed in the UI for $0 pricing ($0 is valid) and adds test coverage to flows.
Changes 🔄
How to test 🧪
Prerequisites
(How to setup test environment)
es-madrid.Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply