-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-7747] - Fix Linode Migration dialog hidden $0 price #10166
fix: [M3-7747] - Fix Linode Migration dialog hidden $0 price #10166
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Nice test coverage!
✅ Migration from Spain shows $0 price to new price.
✅ Migration to Spain shows old price to $0 price.
✅ Backups price displays when backups are enabled on the linode and are $0 when the linode's region is Spain.
packages/manager/src/features/Linodes/MigrateLinode/MigrationPricing.test.tsx
Outdated
Show resolved
Hide resolved
…10166) * Add unit tests for MigrationPricing component * Accounting for $0 prices in MigrationPricing component
…xes for release (#10177) * fix: [M3-7741] - Hide error notices for $0 regions in Resize Pool and Add a Node Pool drawers (#10157) * Allow -zsh LKE prices without error notices in Resize Pool and Add Pool drawers * Fix loading spinner displaying above what was supposed to be loading * Fix conditional to render notice if either price is invalid * Add test coverage * Added changeset: Hide error notices for /bin/sh regions for LKE Resize and Add Node Pools * Fix changeset wording * Address feedback: use invalid price util * fix: [M3-7746] - Fix $0 region price error in "Enable All Backups" drawer (#10161) * Remove error indicator for Linodes in $0 regions * Fix $0 total price display issue * Cover $0 pricing cases in Cypress backup tests * Add BackupLinodeRow tests to account for error states and $0 regions * Add unit tests for BackupDrawer component * fix: [M3-7747] - Fix Linode Migration dialog hidden $0 price (#10166) * Add unit tests for MigrationPricing component * Accounting for $0 prices in MigrationPricing component * fix: [M3-7739] - Fix error when enabling backups for Linodes in regions with $0 price (#10153) * Fix error when enabling backups for Linodes in regions with $0 price * Add unit tests for EnableBackupsDialog --------- Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Replace "toBeDisabled" with "toHaveAttribute" assertion --------- Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Description 📝
When migrating to or from a region with $0 pricing, the Linode migrate dialog hides the $0.00 price. This fixes the issue and adds some unit tests.
Changes 🔄
List any change relevant to the reviewer.
Preview 📷
How to test 🧪
To run the new unit tests:
yarn test MigrationPricing.test
To run related Cypress tests:
yarn && yarn build && yarn start:manager:ci
and thenyarn cy:run -s "cypress/e2e/core/firewalls/migrate-linode-with-firewall.spec.ts,cypress/e2e/core/linodes/migrate-linode.spec.ts"
Manual verification:
Using an account with access to
es-mad
, create a Linode ines-mad
, wait for it to provision and boot, and then open the Migration dialog (via either the Linode landing page or details page). Confirm that after selecting a new region, the $0 price is displayed for Madrid.Similarly, you can create a Linode in another region, open the Migration dialog, select Madrid for the new region, and confirm that $0 appears.
As an Author I have considered 🤔
Check all that apply