Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Updated PG migrations field to be pointer #639

Merged

Conversation

ezilber-akamai
Copy link
Contributor

📝 Description

Changed migrations field of PlacementGroup to be a pointer to fit the API contract. Also, updated several instances that were being created with an image of linode/debian9, which is no longer supported.

✔️ How to Test

make testint
make testunit

@ezilber-akamai ezilber-akamai added the bugfix for any bug fixes in the changelog. label Dec 5, 2024
@ezilber-akamai ezilber-akamai requested a review from a team as a code owner December 5, 2024 21:19
@ezilber-akamai ezilber-akamai requested review from lgarber-akamai and yec-akamai and removed request for a team December 5, 2024 21:19
@lgarber-akamai lgarber-akamai added the breaking-change for breaking changes in the changelog. label Dec 6, 2024
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for fixing this!

Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@ezilber-akamai ezilber-akamai merged commit 55f9fb9 into linode:main Dec 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change for breaking changes in the changelog. bugfix for any bug fixes in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants