Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for missing Obj-related endpoints #634

Merged

Conversation

ezilber-akamai
Copy link
Contributor

@ezilber-akamai ezilber-akamai commented Nov 26, 2024

📝 Description

Added support for the GET object-storage/buckets/$1/$2/object-list endpoint. Also reran some fixtures that were not properly sanitized.

✔️ How to Test

make testunit
make testint

@ezilber-akamai ezilber-akamai requested a review from a team as a code owner November 26, 2024 21:15
@ezilber-akamai ezilber-akamai requested review from zliang-akamai and yec-akamai and removed request for a team November 26, 2024 21:15
@ezilber-akamai ezilber-akamai added the improvement for improvements in existing functionality in the changelog. label Nov 26, 2024
@ezilber-akamai ezilber-akamai force-pushed the TPT-3240-missing-obj-endpoints branch from 4082f44 to 9518d4c Compare November 27, 2024 14:27
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed locally!

@zliang-akamai
Copy link
Member

zliang-akamai commented Dec 6, 2024

Can we use Google's go-querystring library to simplified query string generation? I think this would be much safer than implementing it in-house.

@ezilber-akamai
Copy link
Contributor Author

Can we use Google's go-querystring library to simplified query string generation? I think this would be much safer than implementing it in-house.

Good idea! This is fixed now.

Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well to me, nice job!

@ezilber-akamai ezilber-akamai merged commit 00343d6 into linode:main Dec 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants