Add support for federated services to the service mirror controller #13269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <alex@buoyant.io>
zaharidichev
reviewed
Nov 5, 2024
| } | ||
| } | ||
|
|
||
| func (rcsw *RemoteClusterServiceWatcher) updateLinkStatus(statusSection, remoteName, namespace string, condition map[string]interface{}) error { |
There was a problem hiding this comment.
Is there any way we get types API for all that? Does it involve regenerating the clients code, etc. We should be able to get the statuses as go types into the API and no rely on the dynamic client? We have some prior art for the HTTPRoute I believe.
There was a problem hiding this comment.
Unfortunately, we use the dynamic client for interacting with Link resources instead of the generated binding. I think we should migrate off the dynamic client and replace it with the generated bindings, but I didn't want to block this work on that.
| } | ||
| } | ||
|
|
||
| func (rcsw *RemoteClusterServiceWatcher) deleteLinkStatus(statusSection, remoteName, namespace string) error { |
There was a problem hiding this comment.
Same comment on types here. I think having explicit status types will simplify things quite a lot.
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
zaharidichev
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the service mirror controller detects a service in the remote cluster which matches the federated service selector (
mirror.linkerd.io/federated=memeberby default), it will add that service to the federated service in the local cluster named<svc>-federated, creating this service if it does not already exist. To join a service to a federated service, it is added to themulticluster.linkerd.io/remote-discoveryannotation on the federated service which contains a comma separated list of values in the form<svc>@<cluster>. When a remote service no longer exists or matches the federated service selector, it is removed from the federated service by removing it from themutlicluster.linkerd.io/remote-discoveryannotation.We also add a new
local-service-mirrordeployment to the Linkerd-multicluster extension which watches the local cluster for any services which match the federated service selector. Any services in the local cluster which match will be added to the federated service by setting themutlicluster.linkerd.io/local-discoveryannotation on the federated service to the local service name.