Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not template non-gateway resources if multicluster is running in gateway mode #13616

Open
RGPosadas opened this issue Jan 30, 2025 · 1 comment

Comments

@RGPosadas
Copy link

RGPosadas commented Jan 30, 2025

What problem are you trying to solve?

#13269 introduces further support for federated services.
The PR modifies the helm chart to add manifests related to local-service-mirror. However, if you are running multicluster in default hierarchical mode, these manifests do not need to be templated/created since they are unused.

How should the problem be solved?

I see two options:

  • Introduce a new toggle to enable the new local service mirror for federated services
  • Use existing toggle gateway.enabled to prevent templating of local-service-mirror manifests if false

Any alternatives you've considered?

N/A, the concern is only related to helm templating.

How would users interact with this feature?

No response

Would you like to work on this feature?

None

@alpeb
Copy link
Member

alpeb commented Feb 12, 2025

That's a good find 👍 Note however that we're considering re-purposing that particular workload in an upcoming multicluster refactoring, so let's keep this one on hold to avoid wasting any efforts 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants