Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netann+docs: remove nil value from variadic list #7922

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

ellemouton
Copy link
Collaborator

@ellemouton ellemouton commented Aug 24, 2023

The nil value in the variadic list causes a panic when the variadic parameters are iterated over.

Fixes #7921

The nil value in the variadic list causes a panic when the variadic
parameters are iterated over.
@hieblmi
Copy link
Collaborator

hieblmi commented Aug 24, 2023

tACK

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦄

@Roasbeef Roasbeef merged commit 15d2ff0 into lightningnetwork:master Aug 24, 2023
20 of 24 checks passed
@saubyk saubyk added this to the v0.17.0 milestone Aug 24, 2023
@ellemouton ellemouton deleted the fixVariadicPanic branch August 24, 2023 20:08
kaloudis pushed a commit to ZeusLN/lnd that referenced this pull request Aug 26, 2023
The nil value in the variadic list causes a panic when the variadic
parameters are iterated over.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: v0.17.0-beta.rc1 panic go-routine on startup
5 participants