Skip to content

Commit

Permalink
netann+docs: remove nil value from variadic list (#7922)
Browse files Browse the repository at this point in the history
The nil value in the variadic list causes a panic when the variadic
parameters are iterated over.
  • Loading branch information
ellemouton committed Aug 24, 2023
1 parent dde1495 commit 15d2ff0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions docs/release-notes/release-notes-0.17.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@
have to make sure to not broadcast outdated transactions which can lead to
locked up wallet funds indefinitely in the worst case.

- [Remove nil value](https://github.com/lightningnetwork/lnd/pull/7922) from
variadic parameter list.

# New Features
## Functional Enhancements
### Protocol Features
Expand Down
2 changes: 1 addition & 1 deletion netann/host_ann.go
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ func IPAnnouncer(annUpdater NodeAnnUpdater) func([]net.Addr,
map[string]struct{}) error {

return func(newAddrs []net.Addr, oldAddrs map[string]struct{}) error {
_, err := annUpdater(nil, func(
_, err := annUpdater(func(
currentNodeAnn *lnwire.NodeAnnouncement) {
// To ensure we don't duplicate any addresses, we'll
// filter out the same of addresses we should no longer
Expand Down

0 comments on commit 15d2ff0

Please sign in to comment.