Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing: send to route max hops check #3818

Merged
merged 3 commits into from
Dec 19, 2019

Conversation

joostjager
Copy link
Contributor

@joostjager joostjager commented Dec 11, 2019

Depends on lightningnetwork/lightning-onion#45

A follow up pr #3841 will also limit path finding to the maximum payload size of 1300 bytes.

Fixes #3712

@joostjager joostjager requested a review from Roasbeef as a code owner December 11, 2019 07:57
@joostjager joostjager self-assigned this Dec 11, 2019
@joostjager joostjager force-pushed the check-max-onion branch 3 times, most recently from 8e05efe to eb48816 Compare December 11, 2019 08:51
@joostjager joostjager requested a review from halseth as a code owner December 11, 2019 09:54
@joostjager joostjager force-pushed the check-max-onion branch 3 times, most recently from 90fb7a3 to 2ae1156 Compare December 11, 2019 14:11
@joostjager joostjager changed the title routing: check for invalid routes [do not review] routing: send to route max hops check Dec 11, 2019
@joostjager joostjager added this to the 0.9.0 milestone Dec 11, 2019
@joostjager joostjager requested review from guggero and halseth and removed request for halseth and guggero December 11, 2019 14:25
@Roasbeef
Copy link
Member

Let's also update this to pin to the latest version of lightning-onion created here: lightningnetwork/lightning-onion#45

@joostjager
Copy link
Contributor Author

Updated to f34e9dc1651d174d79cc7a9965ac26844eb4ec98

@joostjager joostjager requested review from guggero and removed request for halseth December 16, 2019 09:20
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice bugfix, looks good to me!
I only have two non-blocking comments/nits.

routing/payment_lifecycle.go Outdated Show resolved Hide resolved
routing/route/route.go Show resolved Hide resolved
@joostjager joostjager merged commit f5b1d40 into lightningnetwork:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LND crashed (panic) during QueryRoutes / SendToRouteSync
4 participants