-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LND crashed (panic) during QueryRoutes / SendToRouteSync #3712
Comments
After restart i have many like these messages. Is it very bad? Possible loss of funds in this case? Or will everything come back with time?
|
Was a route with more than 20 hops provided?
They can be ignored. We had a recent change that caused these to be logged without it actually being a fatal error, but we've yet to address that (see #3656). |
Yes, sounds like max hops exceeded. We need to fix that. From the code
|
I no longer have detailed logs from my scripts about this incident. But may be... |
Do you append hops to the result from Still no reason to crash :) |
No
After fail payment i add one failed direct way (parsed from error of I think this bug should be fixed otherwise every time of rebalancing i will repair LND and write here new logs ;-) |
The code there i caught this crash is here (NodeJS): https://gist.github.com/LNBIG-COM/90f143c8ba61b848eb33dc4253a90425 |
I think you do append in that code? Side note: I see your |
First, I do not calculate the complete route, but to the N-1 node, then I add the last hop (receiver). Without this, it is impossible to calculate a route for rebalancing - for example, when node A wants to find a route to node A (but to a different channel) - without this lnd will say that there are no routes. I wrote about this here: #3689 |
May be. I don't know about this. This function is missed in lnd-0.8.0-beta |
Yes, I understand that that is necessary. But I also think that pushes the route length to 21 hops. But issue is clear, I will think about a solution. There is also no way currently to limit the max route length with queryroutes. Otherwise you could set it to 19 and still be able to add the last hop manually. |
Ohh, may be. Thanks for this info. I didn't think about this ;-)
I will do! Thanks! |
Currently, you unfortunately cannot set the max number of hops on a queryroutes call. But at least you can check whether the route returned from queryroutes is 20 hops. If that is the case, don't fire |
The limitation is already there and while the flight is normal :) |
Related issue: #3725 |
Background
I had intense code executions
QueryRoutes
/SendToRouteSync
with big lists of ignored_pairs & ignored_nodes. One from LNDs (lnd-01) was crashedYour environment
lnd
- 0.8.0-betaSteps to reproduce
May be intense rebalancing through QueryRoutes (with
ignored_pairs
&ignored_nodes
) -> SendToRouteSync executions.stacktrace:
The text was updated successfully, but these errors were encountered: