Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account max onion blob size when pathfinding #3725

Closed
joostjager opened this issue Nov 14, 2019 · 1 comment
Closed

Take into account max onion blob size when pathfinding #3725

joostjager opened this issue Nov 14, 2019 · 1 comment
Labels
onion routing payments Related to invoices/payments routing

Comments

@joostjager
Copy link
Contributor

joostjager commented Nov 14, 2019

Currently pathfinding for QueryRoutes and SendPayment assumes a fix hop limit of 20 hops. This is no longer true now that there is the variable-size tlv payload.

With a variable payload it is possible to have more than 20 hops. But the maximum number of hops could also be less, for example when a large custom field is delivered to one of the hops.

Pathfinding needs to take the onion payload size into account.

Possibly we also need the option to pass in an external 'reserve' size, to allow for applications that use the QueryRoutes result and append additional hops. This is typically done for rebalancing channels (send to self).

@Roasbeef
Copy link
Member

Fixed #3841.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onion routing payments Related to invoices/payments routing
Projects
None yet
Development

No branches or pull requests

2 participants