This repository has been archived by the owner on Nov 22, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kafka external sharding strategy #418
Kafka external sharding strategy #418
Changes from 41 commits
0380f89
03e27bd
c3789e3
9662794
f42cb02
6c4e811
59b884a
8823432
bd6dd98
46aa0d2
95dd77a
85f7a3a
80535c7
9dda8ee
1ef1cd0
dbb55e2
fda5823
ccb81a3
36d632e
b89442b
378a056
e8a12fc
3aec21c
0132abf
fec8a2d
ae51d52
ee8764e
b0ef068
b6ddeca
cba01a0
ae50240
3f996cb
bc59c86
09d174f
51489b4
75a239d
71b555d
736586a
af64fdf
cc02d17
2b7d77b
0541895
ef99370
879fe7b
c0e1a15
bc962ca
868cd6f
77af7a4
dad2d09
ad6c144
ef9adb2
8defbb9
27a40b1
bcdee41
ae9d9df
f098bb4
9fd6931
c69e023
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to have the control available in the materialized value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, I agree but maybe something that should be implemented in a separate PR because all of the existing cloudflow sources are implemented in the same way. @RayRoestenburg what are your thoughts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ennru @nolangrace yes leave as is in this PR, and add an issue to change the signature to expose the control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added #638 . The idea has always been that cloudflow takes care of draining etc, but it's better to provide it than to provide NotUsed.