This repository has been archived by the owner on Nov 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 90
Kafka external sharding strategy #418
Merged
Merged
Changes from all commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
0380f89
working on implementing external sharding
03e27bd
kafka sharding implemented but untested
c3789e3
merged dependencies
9662794
still working
f42cb02
Merge branch 'master' of github.com:nolangrace/cloudflow into kafka-s…
6c4e811
update shardedSourceWithCommittableContext to return Source.future
59b884a
add cluster sharding typed dependency
8823432
Akka Kafka Sharding working and new Source.future implementation working
bd6dd98
restructure akka kafka sharding implementation and connected car example
46aa0d2
fix generics for akka kafka sharding
95dd77a
clean up akka actor
85f7a3a
merged with master
80535c7
remove accidental changes to call-record-aggregator
9dda8ee
update shardedPlainSource
1ef1cd0
add javaapi for plain and committable kafka sharded source
dbb55e2
add scaladoc for shardedSourceWithCommittableContext and shardedPlain…
fda5823
implement akka sharded source test functions
ccb81a3
fix new line
36d632e
create Cluster and shardedSource Documentation
b89442b
implement clusterSharding(system.toTyped) helper method in AkkaStream…
378a056
remove old ClusterSharding helper from AkkStreamletContextImpl
e8a12fc
upgrade alpakkakafka to 2.0.3+13-0455a136
3aec21c
Merge branch 'master' of github.com:lightbend/cloudflow into kafka-sh…
0132abf
resolve conflict
fec8a2d
change kafkaSharding to use messageExtractor rather than messageExtra…
ae51d52
update kafka sharded docs
ee8764e
remove entityIdExtractor from sharded source Testkit
b0ef068
add api may change annotation to sharded sources
b6ddeca
experimental warning added to the top of the cluster and external sha…
cba01a0
update alpakka kafka to 2.0.4
ae50240
set connected car to cloudflow 2.1.0-snapshot
3f996cb
update connected car version
bc59c86
Update docs/shared-content-source/docs/modules/develop/pages/clusteri…
09d174f
Update docs/shared-content-source/docs/modules/develop/pages/clusteri…
51489b4
Update docs/shared-content-source/docs/modules/develop/pages/clusteri…
75a239d
Update docs/shared-content-source/docs/modules/develop/pages/clusteri…
71b555d
Update docs/shared-content-source/docs/modules/develop/pages/clusteri…
736586a
Update docs/shared-content-source/docs/modules/develop/pages/clusteri…
af64fdf
Update core/cloudflow-akka/src/main/scala/cloudflow/akkastream/AkkaSt…
cc02d17
Update core/cloudflow-akka/src/main/scala/cloudflow/akkastream/AkkaSt…
2b7d77b
Update docs/shared-content-source/docs/modules/develop/pages/clusteri…
0541895
Update docs/shared-content-source/docs/modules/develop/pages/clusteri…
ef99370
change sharded source signature to use NotUsed
879fe7b
Update core/cloudflow-akka/src/main/scala/cloudflow/akkastream/AkkaSt…
c0e1a15
fix TextContext and remove implicit execution context from AkkaStream…
bc962ca
Merge branch 'kafka-sharding' of github.com:nolangrace/cloudflow into…
868cd6f
remove alpakka shapshots from connected car example
77af7a4
Update docs/shared-content-source/docs/modules/develop/pages/clusteri…
dad2d09
Update docs/shared-content-source/docs/modules/develop/pages/clusteri…
ad6c144
Update docs/shared-content-source/docs/modules/develop/pages/clusteri…
ef9adb2
Update docs/shared-content-source/docs/modules/develop/pages/clusteri…
8defbb9
Update docs/shared-content-source/docs/modules/develop/pages/clusteri…
27a40b1
Update docs/shared-content-source/docs/modules/develop/pages/clusteri…
bcdee41
add sharded when logging info for sharded sources
ae9d9df
fix bug in shardedSourceWithContext Test kit
f098bb4
Merge branch 'kafka-sharding' of github.com:nolangrace/cloudflow into…
9fd6931
added timeout config to sharded sources
c69e023
Fix logging
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to have the control available in the materialized value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, I agree but maybe something that should be implemented in a separate PR because all of the existing cloudflow sources are implemented in the same way. @RayRoestenburg what are your thoughts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ennru @nolangrace yes leave as is in this PR, and add an issue to change the signature to expose the control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added #638 . The idea has always been that cloudflow takes care of draining etc, but it's better to provide it than to provide NotUsed.