-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Various JSON schema REST API export fix and enhancements #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgschwan
force-pushed
the
json-schema-enhancements
branch
2 times, most recently
from
March 3, 2021 13:29
c9363bb
to
d04592e
Compare
fgschwan
changed the title
WIP fix: Various JSON schema REST API export fix and enhancements
fix: Various JSON schema REST API export fix and enhancements
Mar 4, 2021
milanlenco
previously approved these changes
Mar 10, 2021
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
… tool (fixed wrong setting of additional properties in inner message-referencing fields) Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
…proto models Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
…d implemented proper json schema export according to new annotation possibilities Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
fgschwan
force-pushed
the
json-schema-enhancements
branch
from
March 10, 2021 14:05
c83c55b
to
ffec426
Compare
fgschwan
changed the title
fix: Various JSON schema REST API export fix and enhancements
WIP fix: Various JSON schema REST API export fix and enhancements
Mar 10, 2021
fgschwan
changed the title
WIP fix: Various JSON schema REST API export fix and enhancements
fix: Various JSON schema REST API export fix and enhancements
Mar 10, 2021
milanlenco
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim for this PR is to change JSON schema generation to be able to generate examples by JSON schema using https://json-schema-faker.js.org/ . These examples should be
There are some code dependencies to not yet merged PR #1787 , therefore this PR is based on the commits of that PR. That means that commits of both PRs are visible here.(rebased)