feat: added REST API for validating yaml VPP-Agent configuration using validate methods on registered descriptors #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g validate methods on registered descriptors Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
…ield names (fields filled in descriptor validator are not enforced to fill correct field value) Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
rewenset
reviewed
Feb 20, 2021
Co-authored-by: Andrii <a.zakurenyi@gmail.com>
milanlenco
reviewed
Mar 1, 2021
|
|
||
| // ValidateSemantically validates given proto messages according to semantic validation(KVDescriptor.Validate) | ||
| // from registered KVDescriptors. If all messages are valid, nil is returned. If all message could be | ||
| // validated, kvscheduler.InvalidMessagesError is returned. In any other case, error is returned. |
There was a problem hiding this comment.
If all message could be validated, kvscheduler.InvalidMessagesError is returned.
Probably mistake in the comment.
plugins/kvscheduler/validation.go
Outdated
| } | ||
| goType := model.LocalGoType() // only for locally known models will return meaningful go type | ||
| if goType == nil { | ||
| return errors.Errorf("dynamic messages for remote models are not supported due to "+ |
There was a problem hiding this comment.
Could there be an option to skip over items with remotely known models instead of returning error?
(i.e. validate everything that can be validated)
There was a problem hiding this comment.
I forgot here about the remote models that are in local registry (the proxied remote models). It will validate everything that can be validated. See 695d734.
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
…or to indicate validation failure Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
|
The new 2 commits are basically fixes of this PR that i did as part of other PR dependent on this one (#1788). So i logically moved them here. |
milanlenco
approved these changes
Mar 1, 2021
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.