Run VPP+VPPAgent in a container for e2e tests (support for multi-VPP tests) #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milan Lenco <lencomilan@gmail.com>
This is a change that affects how VPP and VPPAgent are started for end-to-end tests. Until now both VPP and VPPAgent processes were started as a processes in the system, which was a special built container for running end-to-end tests. However to allow for multi-VPP tests and make the execution of tests closer match the real use it is better to run VPP+VPPAgent using a separate container that is normally built. Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
ondrej-fabry
changed the title
milanlenco
previously approved these changes
Dec 14, 2020
Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech>
# Conflicts: # tests/e2e/e2e.go
…ssignment (ligato#1773) Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
# Conflicts: # plugins/linux/ifplugin/descriptor/interface_vrf.go # tests/e2e/012_linux_interfaces_test.go # tests/e2e/080_vrf_test.go # tests/e2e/101_rest_api_test.go # tests/e2e/e2e.go
|
All tests passing: |
fgschwan
requested changes
Dec 16, 2020
fgschwan
reviewed
Dec 17, 2020
fgschwan
reviewed
Dec 17, 2020
fgschwan
reviewed
Dec 17, 2020
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
fgschwan
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change that affects how VPP and VPPAgent are started for end-to-end tests.
Until now both VPP and VPPAgent processes were started as a processes in the system,
which was a special built container for running end-to-end tests. However to allow
for multi-VPP tests and make the execution of tests closer match the real use it is
better to run VPP+VPPAgent using a separate container that is normally built via
make images.This PR currently seems to conflict with #1769 so it seems we need to orchestrate the changes.