Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added possibility to setup NB configuration from file at VPP-Agent start #1769

Merged
merged 11 commits into from
Dec 21, 2020

Conversation

fgschwan
Copy link
Collaborator

@fgschwan fgschwan commented Dec 8, 2020

Added possibility to define NB configuration as file and to picked up and applied by VPP-Agent at start.
Additional features:

  • file defined as yaml
  • ability to set up also 3rd party models (using the same components as are used for agentctl config update --replace, see this issue for understanding more about 3rd party model definition/problems)
  • by default active, no additional configuration needed to use (create nb-initial-config.yaml in vpp-agent working directory, i.e. if you installed vpp-agent binary in one of paths from env.variable then nb-initial-config.yaml must be in that directory where you are when you execute vpp-agent binary - if you are still not sure about the location, don't worry, VPP-agent will tell you in debug logging where it expects the file to be by using absolute file path)
  • fully configurable (path to configuration yaml file + feature on/off switch)
  • usable in projects using VPP-Agent as its base (using the updated code in VPP-Agent plugin setup will allow usage of this feature)
  • basic merging capabilities for NB configuration coming from different data sources (NB init file source is just another source among others like etcd and others) - in case of colliding data, other sources have priority to initial NB config file
  • e2e tests (start with NB init file, start with Etcd with data, start with both sources having data and merge colliding data - etcd data is used in the end)

@fgschwan
Copy link
Collaborator Author

fgschwan commented Dec 8, 2020

I ran e2e and integration test for VPP 20.01/20.05/20.09 and it passed for current PR state.

@fgschwan fgschwan changed the title WIP feat: Added possibility to setup NB configuration from file at VPP-Agent start feat: Added possibility to setup NB configuration from file at VPP-Agent start Dec 8, 2020
@fgschwan fgschwan requested a review from ondrej-fabry December 8, 2020 18:34
@fgschwan fgschwan changed the title feat: Added possibility to setup NB configuration from file at VPP-Agent start WIP feat: Added possibility to setup NB configuration from file at VPP-Agent start Dec 9, 2020
@fgschwan
Copy link
Collaborator Author

I ran e2e and integration test for VPP 20.01/20.05/20.09 and it passed for current PR state.

…ent start

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
…ent start

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
…of dynamic proto message to generated proto message

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
…nfig loading

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
…f locally registered models

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
…olume for passing config files, etc.)

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
Copy link
Collaborator Author

Rebased changes from merged e2e test changes (#1770).
Unit/integration/e2e tests for vpp 20.05 passed ok.

@fgschwan fgschwan changed the title WIP feat: Added possibility to setup NB configuration from file at VPP-Agent start feat: Added possibility to setup NB configuration from file at VPP-Agent start Dec 17, 2020
@ondrej-fabry ondrej-fabry merged commit 27364fa into ligato:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants