-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added possibility to setup NB configuration from file at VPP-Agent start #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran e2e and integration test for VPP 20.01/20.05/20.09 and it passed for current PR state. |
fgschwan
changed the title
WIP feat: Added possibility to setup NB configuration from file at VPP-Agent start
feat: Added possibility to setup NB configuration from file at VPP-Agent start
Dec 8, 2020
fgschwan
changed the title
feat: Added possibility to setup NB configuration from file at VPP-Agent start
WIP feat: Added possibility to setup NB configuration from file at VPP-Agent start
Dec 9, 2020
ondrej-fabry
reviewed
Dec 9, 2020
I ran e2e and integration test for VPP 20.01/20.05/20.09 and it passed for current PR state. |
…ent start Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
…ent start Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
…of dynamic proto message to generated proto message Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
…nfig loading Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
…f locally registered models Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
…olume for passing config files, etc.) Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
fgschwan
force-pushed
the
nb-init-file
branch
from
December 17, 2020 19:59
d7d34d3
to
f0e46c0
Compare
Rebased changes from merged e2e test changes (#1770). |
fgschwan
changed the title
WIP feat: Added possibility to setup NB configuration from file at VPP-Agent start
feat: Added possibility to setup NB configuration from file at VPP-Agent start
Dec 17, 2020
ondrej-fabry
approved these changes
Dec 21, 2020
milanlenco
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added possibility to define NB configuration as file and to picked up and applied by VPP-Agent at start.
Additional features:
agentctl config update --replace
, see this issue for understanding more about 3rd party model definition/problems)nb-initial-config.yaml
in vpp-agent working directory, i.e. if you installed vpp-agent binary in one of paths from env.variable thennb-initial-config.yaml
must be in that directory where you are when you execute vpp-agent binary - if you are still not sure about the location, don't worry, VPP-agent will tell you in debug logging where it expects the file to be by using absolute file path)