Skip to content
This repository has been archived by the owner on Jan 26, 2023. It is now read-only.

Error on empty feature #172

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Error on empty feature #172

merged 2 commits into from
Jul 21, 2022

Conversation

fmorency
Copy link
Contributor

Fixes #169

Draft PR until liftedinit/many-rs#159 is merged and this PR updated.

@fmorency
Copy link
Contributor Author

CI fails because of this nightly ICE: rust-lang/rust#99271

@codecov-commenter
Copy link

Codecov Report

Merging #172 (abaa189) into main (0a53be8) will increase coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   61.50%   61.74%   +0.23%     
==========================================
  Files          31       31              
  Lines        6936     6976      +40     
==========================================
+ Hits         4266     4307      +41     
+ Misses       2670     2669       -1     
Impacted Files Coverage Δ
src/many-ledger/src/module.rs 67.82% <100.00%> (+0.28%) ⬆️
src/many-ledger/tests/account.rs 91.98% <100.00%> (+0.54%) ⬆️

@fmorency fmorency marked this pull request as ready for review July 20, 2022 20:36
@fmorency fmorency merged commit 2205224 into liftedinit:main Jul 21, 2022
@fmorency fmorency deleted the fmorency/bug-169-empty-feature branch July 21, 2022 21:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

calling account.create and account.addFeatures with empty features should Error
3 participants