This repository has been archived by the owner on Jan 26, 2023. It is now read-only.
calling account.create and account.addFeatures with empty features should Error
#169
Assignees
Labels
bug
Something isn't working
Comments
tt0mmy
changed the title
account.create without any features should throwaccount.create without any features should Error
tt0mmy
changed the title
account.create without any features should Erroraccount.create and account.addFeatures features should Error
This was referenced Jul 15, 2022
Merged
tt0mmy
changed the title
account.create and account.addFeatures features should Erroraccount.create and account.addFeatures with empty features should Error
fmorency
added a commit
that referenced
this issue
Jul 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
Per spec https://github.com/many-protocol/specification/blob/main/attributes/network/cddl/9_account.cddl#L96 and https://github.com/many-protocol/specification/blob/main/attributes/network/cddl/9_account.cddl#L248, calling
account.createandaccount.addFeaturesshould require at least one feature in the set.To Reproduce
Steps to reproduce the behavior:
account.createoraccount.addFeatureswith an empty set of features.Expected behavior
An error should be returned if an empty set of features is provided.
Additional context
probably need changes here https://github.com/liftedinit/many-framework/blob/main/src/many-ledger/src/module.rs#L49
The text was updated successfully, but these errors were encountered: