-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New infra from clayui.com with Gatsbyjs #1040
Conversation
Pull Request Test Coverage Report for Build 1000
💛 - Coveralls |
Hey @matuzalemsteles, @diegonvs, great work, this is looking great! @carloslancha, @julien, mind taking a look tomorrow to see what you think? I'm a bit confused by the live editor... having to show an Also, now that the cdn links are working, I think it should be fine to remove tha specific page and just add the copy/pasteable snippet in the Finally, can you explain the algolia search a bit more? Where's the API key coming from? What are their usage limitations? When developing, results will go straight to the published site, is there a way to test that locally? Looking great, I'm really excited about this!! 👏 |
/cc @zenorocha, what do you think about this? |
hey @jbalsas, Thanks! 🎉
Yes, we can test locally but the data is from the live site, they index our site and have provided a key for us. You can see its implementation here a57b996. It searches for key words we type in the content of the site and also separates them by categories according to our Sidebar and offers suggestions of other similar pages (The settings can be seen here https://github.com/algolia/docsearch-configs/blob/master/configs/clay.json), the developer can click and he will be redirected to Clay website in the part he chose. More information on how they do internally can be seen on the site. DocSearch is being actively used by the community, some examples can be seen at site. 🙂
Yes I thought of removing this too, but we have a point in favor of this, developers can create more complex interactions in Live Editor, like adding click events and interactions with more than one component. This gives many possibilities for developers to experiment with Try. I can go with just the developer typing in the markup of the component and then joining it with an We can go with both possibilities, the user type only the markup of the component we make the approach "under the table" and if it passes a
Oh yes, we can. It makes sense, I only care if people will easily find the link. Maybe... I'll go with that. |
Looks promising! |
Hey @matuzalemsteles good work! I checked it out and here are my comments
|
hey @julien Thanks for feedback! I made the changes based on your feedbacks, thanks guys! |
Just started reviewing :) |
1 similar comment
Just started reviewing :) |
I'm merging so we can publish this ahead of the official release tomorrow and have the site ready. Site looks great, we should be able to work on top of this from now on :) Great job @matuzalemsteles, @diegonvs! |
I'm glad to see this merged! What are the possibilities to have this for other sites? |
We will be working on the others under our control in the next months. Not sure what we can do with the existing electric user-base, though... 🤔 |
This is the new infra of the Clay website using Gatsbyjs.
New
We've added some news to improve the developer experience with the website:
Maintenance of documentation
Try
page inside theclayui.com/examples
folder, the file name will be reflected in the Sidebar of the page.clayui.com/content
folder, but are not automatically reflected in the Sidebar, you need to add it inside thesrc/data/sidebars/doc-links.yaml
file.Disclaimer
Ideas