Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clayui.com https://clayui.com/docs/getting_started/introduction.html #962

Closed
codeexcursion opened this issue May 31, 2018 · 7 comments
Closed

Clayui.com https://clayui.com/docs/getting_started/introduction.html #962

codeexcursion opened this issue May 31, 2018 · 7 comments
Labels
comp: documentation Issues related to documentation in general, be clayui.com or other means... type: bug Issues reporting that Component is not doing what should be done

Comments

@codeexcursion
Copy link

This isn't working in Edge, Firefox 60.0.1 or the latest Chrome. OS is Win 10. Getting "Error: Namespace "goog.string" already declared." in console. If there is a more appropriate place to report this please let me know.
@codeexcursion
Copy link
Author

A screenshot
introduction

@codeexcursion
Copy link
Author

codeexcursion commented Jun 4, 2018 •
edited
Loading

This works in Firefox 60.0.1 on Fedora 28. Is this being checked from Windows 10 regularly?

@matuzalemsteles
Copy link
Member

hey @ChrisLynch42, Really this page is broken. Maybe it was when we was generating the pages with Electric ... It has to be fixed.

This works find in Firefox 60.0.1 on Fedora 28. Is this being checked from Windows 10 regularly?

We do not regularly test in Win 10 unfortunately, but it's supposed to work regardless of the operating system.

Thanks!

@matuzalemsteles matuzalemsteles added type: bug Issues reporting that Component is not doing what should be done comp: documentation Issues related to documentation in general, be clayui.com or other means... labels Jun 4, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Jun 9, 2018
@matuzalemsteles
Remove tag | Fixes liferay#962
fdb588d
@codeexcursion
Copy link
Author

I checked the page this morning. It isn't working on Linux or windows.

@bryceosterhaus
Copy link
Member

btw, Error: Namespace "goog.string" already declared. is a typical error if metal.js is imported more than once. It happens when there are multiple instances of IncrementalDOM

@jbalsas
Copy link
Contributor

jbalsas commented Jun 11, 2018

Yes, as hinted by @matuzalemsteles attempt at a fix, the electric is failing to properly escape the cdn snippet which is causing metal to be included twice.

This has been actually fixed in later versions, so I suspect electric is also using an older one that might be playing here.

We're considering how to proceed :(

@matuzalemsteles
Copy link
Member

This has been fixed at #1040.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: documentation Issues related to documentation in general, be clayui.com or other means... type: bug Issues reporting that Component is not doing what should be done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jbalsas @codeexcursion @bryceosterhaus @matuzalemsteles